Should we release 0.71.9?

[kelset]

released, please refer to #70

---

Current Release: 0.71.8

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of qualified picks

1. picked facebook/react-native@98009ad
2. picked facebook/react-native@012e4bd
3. Make CircleCI caches for hermesc be version dependent facebook/react-native#37452 - facebook/react-native@c56968c
4. picked facebook/react-native@2558c3d
5. picked facebook/react-native@94356e1
6. Hermes side bump
   • with facebook/hermes@f2f1a2e (ran into a conflict, need help from Hermes Use original Error.prototype.toString for formating Error.stack facebook/hermes#1023)

Local commits to backport to main

[kelset]

From previous patch discussion, from @leotm :

could we pos bump 0.71-stable/sdks/.hermesversion hermes-2023-03-07-RNv0.71.4-31fdcf738940875c9bacf251e149006cf515d763
to address this Hermes crash facebook/hermes#886 (so bump would include facebook/hermes@f2f1a2e from 2023-03-23)

Further explanation:

for our MetaMask/metamask-mobile#6220 (wip) we patched the lib, then later updated the proj to build from source with custom Hermes build (0.71.6 tag + facebook/hermes@f2f1a2e cherry-picked) and tested w/o the lib patch (gr8 success)
removed it now and MetaMask/metamask-mobile#6220 (comment) to confirm

[kelset]

hey @leotm a quick update on this: we tried to cherry pick it but we hit a number of issues so we'll hold off from making this Hermes change.

[leotm]

np thx for the update ^ and appreciate the effort

[douglowder]

Once merged, please include facebook/react-native#37445

[kelset]

facebook/react-native#37452

[iceuponfire]

Please include facebook/react-native#36067

[sunnylqm]

Enable RuntimeScheduler in old architecture
facebook/react-native@7211ef1
facebook/react-native@133ccdc

[Saadnajmi]

is this to fix performance regressions seen on the old architecture since 0.70/71 ish?

[cipolleschi]

Yea, we believe that this should be the fix. We would like to first double check that with RC.4. If confirmed, we will try to backport it to older versions, if feasible.

[Saadnajmi]

Thanks! We may also try locally testing this as well!

[fortmarek]

@cipolleschi has this regression been introduced in 0.71 or do we need to backport the fix to previous releases, too? It sounds like we'll need to backport it to 0.70 at least.

EDIT:
Based on this commit, the regression is there from 0.69.

[cortinico]

Hey all,
This is not easily backportable as we would also need to bump the scheduler version to the canary version we'll be using in 0.72.
We'll hold on backporting this for the time being. We first want to validate that the fix for 0.72 works for the majority of users and we'll consider eventually backporting it

[ste7en]

This adds string type to the transform style prop facebook/react-native@2558c3d

[xsjcTony]

Please include facebook/react-native@94356e1
This fix the type for autoComplete prop of TextInput

[lunaleaps]

I'm attempting to bump Hermes but ran into a conflict. Can someone from the Hermes team take a look?
facebook/hermes#1023

[cipolleschi]

I took a stab at merging the conflict. The problem was that the PR updates a test file that was not there in 0.71-stable.
I saw that the PR is also introducing a new tests and updating a couple of older ones, so I decided to resolve the conflict by adding the modified test on the Repo. If the CI is happy, I think we are good to go!

[cipolleschi]

At the end, this change is incompatible with the status of Hermes of 0.71. It changes how some things behave and more tests and configurations are failing. We decided not to pick it. See here

@lunaleaps do you think we can close the PR or do you still want for the Hermes team to have a look at it?

[leotm]

appreciate the effort ^ would be great if Hermes team could take a look

[lunaleaps]

From this discussion we'll proceed 0.71.9 without a Hermes bump.