Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Option to remove '' and null #126

Closed
JoshuaKGoldberg opened this issue Dec 24, 2024 · 1 comment · Fixed by #128
Closed

Feature: Option to remove '' and null #126

JoshuaKGoldberg opened this issue Dec 24, 2024 · 1 comment · Fixed by #128
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JoshuaKGoldberg
Copy link
Contributor

👋 Thanks for this project! It's almost exactly what I need. One request: could we have an option to remove '' and null properties too, please?

Context: I'm writing an templating engine that generates repository files such as JSON files. For specific files such as package.json, it's nice to remove empty values.
@erunion erunion added enhancement New feature or request good first issue Good for newcomers labels Dec 24, 2024
@erunion erunion self-assigned this Dec 24, 2024
@erunion
Copy link
Member

erunion commented Jan 7, 2025

@JoshuaKGoldberg That'd be awesome. I'm unfortunately pretty swamped so I'm not sure when I'll be able to to get to this but if you're up for adding a second optional argument to the library to facilitate this I'd happily pull it in.

@erunion erunion removed their assignment Jan 7, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add removeAllFalsy option JoshuaKGoldberg/remove-undefined-objects
2 participants
@erunion @JoshuaKGoldberg