Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain page when switching version through warning banner #387

Closed
michellewang opened this issue Sep 27, 2024 · 1 comment · Fixed by #390
Closed

Retain page when switching version through warning banner #387

michellewang opened this issue Sep 27, 2024 · 1 comment · Fixed by #390
Labels
Needed: design decision A core team decision is required

Comments

@michellewang
Copy link

Hello,

I noticed that when I click the version switching link on the warning banner (for both dev and old versions), it brings me back to the home page. This is different from the flyout menu, where switching versions retains the page the user is currently viewing. Would it be possible to implement this behaviour in the warning banner too?

Related issues:
@humitos humitos added the Needed: design decision A core team decision is required label Sep 30, 2024
@humitos
Copy link
Member

humitos commented Sep 30, 2024

Do you have an example where the unexpected behavior is happening and how it should behave? Thanks

humitos added a commit that referenced this issue Oct 1, 2024
@humitos
Notifications: stay on the same page when switching version
0340c50 
This commit implements the same behavior we have in the flyout. If you are
looking at the page `mypage.html` and you click on another version, we keep the
user on `mypage.html` for that "another version".

Now, we implemented the same for the notifications.

Closes #387
@humitos humitos mentioned this issue Oct 1, 2024
Merged
humitos added a commit that referenced this issue Oct 2, 2024
@humitos
Notifications: stay on the same page when switching version (#390)
46b3105 
This commit implements the same behavior we have in the flyout. If you
are
looking at the page `mypage.html` and you click on another version, we
keep the
user on `mypage.html` for that "another version".

Now, we implemented the same for the notifications.

Closes #387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notifications: stay on the same page when switching version readthedocs/addons
2 participants
@humitos @michellewang