Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we have clang-format installed on CI runners when generating bindings #6594

Closed
kraenhansen opened this issue Apr 4, 2024 · 2 comments
Closed

Ensure we have clang-format installed on CI runners when generating bindings #6594

kraenhansen opened this issue Apr 4, 2024 · 2 comments
Labels
T-Internal

Comments

@kraenhansen
Copy link
Member

kraenhansen commented Apr 4, 2024 •
edited
Loading

With the merge of realm/realm-core#7554 we'll need to ensure that any workflows which are generating C++ binding code has a clang-format executable installed. This is mostly a reminder to the next person upgrading core and wondering why generating the binding is failing.

We should also update our contrib docs to mention the need to install it.
@sync-by-unito Sync by Unito
Copy link

sync-by-unito bot commented Apr 4, 2024

➤ PM Bot commented:

Jira ticket: RJS-2791

@kraenhansen
Copy link
Member Author

This was handled by the added dependency on trunk in #6598.

@kraenhansen kraenhansen closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Internal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kraenhansen