Remove all uses of freeze #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmelchior
requested review from
rorbech and
clementetb
and removed request for
rorbech
rorbech
approved these changes
Mar 13, 2023
added 2 commits
March 13, 2023 10:05
# Conflicts: # packages/test-base/src/androidAndroidTest/kotlin/io/realm/kotlin/test/shared/notifications/RealmListNotificationsTests.kt # packages/test-base/src/androidAndroidTest/kotlin/io/realm/kotlin/test/shared/notifications/RealmSetNotificationsTests.kt
|
Hi! This is all great, but the documentation on mongodb.com has not been updated to reflect this fact, which was confusing since I knew that "freezing" was no longer necessary in Kotlin/Native. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1294
This PR removes all uses of
freeze. It was already a no-op when moving to the new memory model and we just kept it to be able to shift back easily. But there has been no pushback against moving to the new memory model, so might as well cleanup the code.