Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GC to close RealmReferences #1527

Open
clementetb opened this issue Sep 25, 2023 · 1 comment
Open

Use GC to close RealmReferences #1527

clementetb opened this issue Sep 25, 2023 · 1 comment

Comments

@clementetb
Copy link
Contributor

Currently, we use the VersionTracker to close realms whose RealmReferences that have been claimed by the GC.

This has two effects:
first versions will not be reclaimed until there is some version advancement;
second, closing realms would be done in the notifier/writer threads, instead of using the GC collector.

We should explore moving close and let the GC thread close and reclaim realms.

@cmelchior
Copy link
Contributor

Hmm, not sure I agree with this. Having a deterministic lifecycle for these versions is pretty nice and makes it easier to reason about what is happening. But we can discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants