Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo Client API's #972

Closed
sync-by-unito bot opened this issue Aug 15, 2022 · 2 comments · Fixed by #1593
Closed

Mongo Client API's #972

sync-by-unito bot opened this issue Aug 15, 2022 · 2 comments · Fixed by #1593
Assignees

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Aug 15, 2022

Similar to Realm Java, we should have support for all the Mongo Client API's here: https://github.com/realm/realm-java/tree/master/realm/realm-library/src/objectServer/java/io/realm/mongodb/mongo

@realm realm deleted a comment from sync-by-unito bot Mar 16, 2023
@cmelchior
Copy link
Contributor

Note, that we will probably be moving App Services to a new package, decoupled from Device Sync. This means that these APIs should not be implemented using the C-API, but be done entirely in Kotlin. .NET has already prototyped the approach here: https://github.com/realm/realm-dotnet/blob/main/Realm/Realm/Sync/MongoClient.cs and maybe we can actually pull the logic from the pre-v10 API's in Java, which was also implemented in Java rather than C++.

@cmelchior
Copy link
Contributor

This was the PR introducing it in Java https://github.com/realm/realm-java/pull/6804/files/0d1b58cc5c0c067b2c1afb0331b6633ff11b8593#diff-669a16424fafec0e99c78f1c5ead6f325bf19fe2207c6b6982d5c006f7538e54. I was misremembering things as we never had a pure Java implementation.

This means we need to duplicate the logic found in https://github.com/realm/realm-core/blob/master/src/realm/object-store/sync/mongo_client.hpp and associated classes

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants