Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: improve exception handling #179

Open
mvidalgarcia opened this issue Apr 27, 2021 · 0 comments
Open

global: improve exception handling #179

mvidalgarcia opened this issue Apr 27, 2021 · 0 comments

Comments

@mvidalgarcia
Copy link
Member

Current behavior

The exception handling of this workflow engine is different from Yadage an Serial ones, where exceptions are propagated to the reana-commons's workflow engine command wrapper. This wrapper takes care of setting the workflow status as failed in case of failure, as well as propagating the logs to the client.

In case of CWL, exceptions are handled locally (See [1], [2], [3], etc.), and eventually propagated to internal cwltool functions.

⚠️ An affected feature of this issue is the k8s user-custom memory limits per job. By using this feature, if the user provides a wrong memory limit (wrong format or over the limits), the exception that occurs is not properly caught and causes the workflow engine to stay forever in running state. More info here.

Expected behavior

Exception handling should behave as Serial and Yadage, where job submission exceptions are caught by reana-commons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant