-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(docker): upgrade base image to ubuntu 24.04 #98
Closed
wirespecter
wants to merge
3
commits into
reanahub:master
from
wirespecter:ubuntu-24.04-docker-image-upgrade
Closed
build(docker): upgrade base image to ubuntu 24.04 #98
wirespecter
wants to merge
3
commits into
reanahub:master
from
wirespecter:ubuntu-24.04-docker-image-upgrade
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=========================================
- Coverage 3.78% 3.66% -0.12%
=========================================
Files 6 6
Lines 185 191 +6
=========================================
Hits 7 7
- Misses 178 184 +6 |
7f5dc31
to
db9cb56
Compare
wirespecter
added a commit
to wirespecter/reana-workflow-engine-snakemake
that referenced
this pull request
Jul 15, 2024
wirespecter
added a commit
to wirespecter/reana-workflow-engine-snakemake
that referenced
this pull request
Jul 15, 2024
db9cb56
to
a8e31a4
Compare
mdonadoni
reviewed
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well locally when running all the examples on Kubernetes. Just left one comment about the Dockerfile changes!
wirespecter
added a commit
to wirespecter/reana-workflow-engine-snakemake
that referenced
this pull request
Jul 16, 2024
a8e31a4
to
c539d20
Compare
wirespecter
added a commit
to wirespecter/reana-workflow-engine-snakemake
that referenced
this pull request
Jul 16, 2024
c539d20
to
0c44114
Compare
wirespecter
added a commit
to wirespecter/reana-workflow-engine-snakemake
that referenced
this pull request
Jul 16, 2024
0c44114
to
3bb7b7e
Compare
wirespecter
added a commit
to wirespecter/reana-workflow-engine-snakemake
that referenced
this pull request
Jul 16, 2024
3bb7b7e
to
6fd313b
Compare
mdonadoni
reviewed
Jul 17, 2024
6fd313b
to
6961a8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana#808