Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italics harcoded for builtins - should have setup option? #216

Open
WVAviator opened this issue Mar 10, 2024 · 1 comment
Open

Italics harcoded for builtins - should have setup option? #216

WVAviator opened this issue Mar 10, 2024 · 1 comment

Comments

@WVAviator
Copy link

I don't like italics in code, and wanted to disable all of them. However, there's no way to disable italics for builtins (i.e. self or this) in the default setup options. After some digging I found that I can set italic = false in the overrides for @variable.builtin, but this was not obvious. The option italic = true is hardcoded for this hlgroup.

require("kanagawa").setup({
  commentStyle = { italic = false },
  keywordStyle = { italic = false },
  overrides = function()
    return {
      ["@variable.builtin"] = { italic = false },
    }
  end
})

While the above config works, what I would like is to be able to do is configure options for builtins similarly to other styles - with italic = true as a default instead of being hardcoded. Something like this:

require("kanagawa").setup({
  commentStyle = { italic = false },
  keywordStyle = { italic = false },
  builtinStyle = { italic = false },
})

If this is infeasible, then perhaps it can be listed in the README under Common Customizations. Surely I'm not the only person who dislikes italics in code.

@MusabDev
Copy link

MusabDev commented May 4, 2024

We want the same for bold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants