Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues with reductions in Graphs #159

Open
Bensuo opened this issue May 5, 2023 · 1 comment
Open

Address issues with reductions in Graphs #159

Bensuo opened this issue May 5, 2023 · 1 comment
Labels
bug Something isn't working Graph Implementation Related to DPC++ implementation and testing

Comments

@Bensuo
Copy link
Collaborator

Bensuo commented May 5, 2023

Reductions currently have several issues in graphs, though they work in some limited cases (where the device supports USM and it happens through record and replay) but there are issues particularly in explicit mode (reduction code expects a device in the handler). These should be addressed for both modes and with buffers and USM.

Accessor support was added in #151 which should help with this issue.

Note: Buffers may be hard to test if we can't force reductions to use them.
@Bensuo Bensuo added bug Something isn't working Graph Implementation Related to DPC++ implementation and testing labels May 5, 2023
EwanC added a commit that referenced this issue May 16, 2023
@EwanC
Move reductions to their own tests
a81455e 
Reduction support is currently
[incomplete](#159) and we
workaround this in the tests with an ifdef. However, this isn't
documented and hides the reduction implementation status.

Instead, move reductions out into their own tests. These current
pass in Recording mode when a device supports USM, but not in
Explicit.
@EwanC EwanC mentioned this issue May 16, 2023
Merged
@EwanC
Copy link
Collaborator

EwanC commented May 16, 2023

As part of #174 some reduction tests have been added, the explicit ones have been marked as XFAIL. As part of actioning this ticket, all these tests should be reliable passes.

Explicit/dotp_buffer_reduction.cpp
Explicit/dotp_usm_reduction.cpp
Explicit/sub_graph_reduction.cpp
RecordReplay/dotp_buffer_reduction.cpp
RecordReplay/dotp_usm_reduction.cpp
RecordReplay/sub_graph_reduction.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EwanC @Bensuo