Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify graph update #323

Open
aharon-abramson opened this issue Sep 14, 2023 · 2 comments
Open

simplify graph update #323

aharon-abramson opened this issue Sep 14, 2023 · 2 comments
Labels
enhancement New feature or request Spec Revision 2 Targetting the second revision of the specification

Comments

@aharon-abramson
Copy link

The suggested graph update mechanism seems computationally complex: an implementation has to traverse both the modifiable and executable graphs to identify any changes to either inputs or outputs.
I better like the OpenCL approach, where one directly updates a cl_mutable_command_khr handle. We can add an update method to class node. We can also add graph::get_node(size_t index) for obtaining the nodes created during queue recording.

@aharon-abramson aharon-abramson added the enhancement New feature or request label Sep 14, 2023
@EwanC EwanC added the Spec Revision 2 Targetting the second revision of the specification label Sep 19, 2023
@EwanC
Copy link
Collaborator

EwanC commented Sep 19, 2023

Hi Aharon, thanks for your input. The current draft update mechanism is aimed at library use cases, where an application creates an graphs from recording a library call, where they don't have access to SYCL objects like buffers/USM to update.

A more fine grained update mechanism is something we're definitely looking at adding for future versions of the spec, so will keep a design like this in mind.

@aharon-abramson
Copy link
Author

Great, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Spec Revision 2 Targetting the second revision of the specification
Projects
None yet
Development

No branches or pull requests

2 participants