util: exclude empty label values for crushlocation map

This commit resolves a bug where node labels with empty values are processed for the crush_location mount option, leading to invalid mount options and subsequent mount failures. Signed-off-by: Praveen M <[email protected]>
red-hat-storage · Jul 16, 2024 · f11fa81 · f11fa81
1 parent 3dd7e8b
commit f11fa81
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/internal/util/crushlocation.go b/internal/util/crushlocation.go
@@ -48,6 +48,10 @@ func getCrushLocationMap(crushLocationLabels string, nodeLabels map[string]strin
 	// Determine values for requested labels from node labels
 	crushLocationMap := make(map[string]string, len(labelsIn))
 	for key, value := range nodeLabels {
+		// label with empty value is not considered.
+		if value == "" {
+			continue
+		}
 		if _, ok := labelsIn[key]; !ok {
 			continue
 		}

diff --git a/internal/util/crushlocation_test.go b/internal/util/crushlocation_test.go
@@ -100,6 +100,17 @@ func Test_getCrushLocationMap(t *testing.T) {
 			},
 			want: map[string]string{"host": "worker-1"},
 		},
+		{
+			name: "matching crushlocation and node labels with empty value",
+			args: input{
+				crushLocationLabels: "topology.io/region,topology.io/zone",
+				nodeLabels: map[string]string{
+					"topology.io/region": "region1",
+					"topology.io/zone":   "",
+				},
+			},
+			want: map[string]string{"region": "region1"},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {