Bug 2225433: rbd: do not execute rbd sparsify when volume is in use #187
Conversation
|
@yati1998: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yati1998
changed the title
|
@yati1998: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yati1998
changed the title
|
@yati1998: This pull request references Bugzilla bug 2225433, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
internal/rbd/errors.go
Outdated
| // ErrFailedPrecondition is returned when operation is rejected because the system is not in a state | ||
| // required for the operation's execution. | ||
| ErrFailedPrecondition = errors.New("system is not in a state required for the operation's execution") | ||
| // ErrUnavailable is returned when the image needs to be recreated | ||
| // locally and may be corrected by retrying with a backoff. | ||
| ErrUnavailable = errors.New("image needs to be recreated") | ||
| // ErrAborted is returned when the operation is aborted. | ||
| ErrAborted = errors.New("operation got aborted") | ||
| // ErrInvalidArgument is returned when the client specified an invalid argument. | ||
| ErrInvalidArgument = errors.New("invalid arguments provided") | ||
| // ErrFetchingLocalState is returned when the operation to fetch local state fails. | ||
| ErrFetchingLocalState = errors.New("failed to get local state") | ||
| // ErrDisableImageMirroringFailed is returned when the operation to disable image mirroring fails. | ||
| ErrDisableImageMirroringFailed = errors.New("failed to disable image mirroring") | ||
| // ErrFetchingMirroringInfo is returned when the operation to fetch mirroring info of image fails. | ||
| ErrFetchingMirroringInfo = errors.New("failed to get mirroring info of image") | ||
| // ErrResyncImageFailed is returned when the operation to resync the image fails. | ||
| ErrResyncImageFailed = errors.New("failed to resync image") |
There was a problem hiding this comment.
These changes were not present in original PR , please check similar backport here https://github.com/red-hat-storage/ceph-csi/pull/186/files
This commit makes sure sparsify() is not run when rbd image is in use. Running rbd sparsify with workload doing io and too frequently is not desirable. When a image is in use fstrim is run and sparsify will be run only when image is not mapped. Signed-off-by: Rakshith R <[email protected]> (cherry picked from commit 98fdadf)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please drop |
|
/bugzilla refresh |
|
@Madhu-1: This pull request references Bugzilla bug 2225433, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
merged commit 3245121
into
red-hat-storage:release-4.12
|
@yati1998: All pull requests linked via external trackers have merged: Bugzilla bug 2225433 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit makes sure sparsify() is not run when rbd image is in use.
Running rbd sparsify with workload doing io and too frequently is not desirable.
When a image is in use fstrim is run and sparsify will be run only when image is not mapped.
Signed-off-by: Rakshith R [email protected]
(cherry picked from commit 98fdadf)