Syncing latest changes from devel for ceph-csi #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments of mkfsOptions and mountOptions are modified to match the real behavior of the code. Signed-off-by: Majid Garoosi <[email protected]>
df-build-team
force-pushed
the
sync_us--devel
branch
from
dd31c1c to
0021f1f
Compare
updating csi spec to v1.9.0 release Signed-off-by: Madhu Rajanna <[email protected]>
Add UnimplementedControllerServer to the default implementation to avoid missing method error. Signed-off-by: Madhu Rajanna <[email protected]>
As we are using UnimplementedControllerServer we dont need to implement mock methods. Signed-off-by: Madhu Rajanna <[email protected]>
df-build-team
force-pushed
the
sync_us--devel
branch
from
0021f1f to
4c07623
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from devel branch