Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #243

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

consider fsName optional for static volume
as it is not required to be set during mount
operation with fuse and kernel client.

fixes: ceph#4311

Signed-off-by: Madhu Rajanna <[email protected]>
added e2e test case to verify static
pvc with and without fsName in the PV
object.

Signed-off-by: Madhu Rajanna <[email protected]>
fsName is optional and its required
to mount the filesystem incase if we have
multiple filesystem in the cluster.

Signed-off-by: Madhu Rajanna <[email protected]>
@df-build-team df-build-team requested a review from a team January 13, 2024 08:07
@Madhu-1
Copy link
Member

Madhu-1 commented Jan 15, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Jan 15, 2024
Copy link

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Jan 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit b7be826 into devel Jan 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants