Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #416

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

seadog007 and others added 3 commits November 18, 2024 09:36
The deploy link in the README is broken.
Fixed more broken links requested by iPraveenParihar in ceph#4958

Signed-off-by: 尤理衡 (Li-Heng Yu) <[email protected]>
this chart currently lack the ability to properly configure encryption,
as well as granting sufficent permission to allow controllers to access
secret when needed.

Signed-off-by: Antoine C <[email protected]>
this allows the encryption KMS config to be granted secret access with
a least privilges policy.

Signed-off-by: Antoine C <[email protected]>
@df-build-team df-build-team requested a review from a team November 19, 2024 08:03
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 19, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Nov 19, 2024
Copy link

openshift-ci bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Nov 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a508a0a into devel Nov 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants