Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream devel for ceph-csi #427

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream devel branch

black-dragon74 and others added 3 commits November 27, 2024 14:37
`ControllerExpandVolume` creates the credentials from
secrets but never actually uses it for anything.

The secrets map is passed on to `NewVolumeOptionsFromVolID`
which does the same check again. This patch removes the
extraneous step.

Signed-off-by: Niraj Yadav <[email protected]>
Bumps the k8s-dependencies group in /api with 1 update: [k8s.io/api](https://github.com/kubernetes/api).

Updates `k8s.io/api` from 0.31.2 to 0.31.3
- [Commits](kubernetes/api@v0.31.2...v0.31.3)

---
updated-dependencies:
- dependency-name: k8s.io/api
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: k8s-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>
Some packages were updated to more recent versions, others were not. Now
everything is at the latest v0.31.3.

Signed-off-by: Niels de Vos <[email protected]>
@df-build-team df-build-team requested a review from a team November 28, 2024 08:03
@Madhu-1
Copy link
Member

Madhu-1 commented Nov 28, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Code looks good label Nov 28, 2024
Copy link

openshift-ci bot commented Nov 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: df-build-team, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Nov 28, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7f4fbdd into devel Nov 28, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Its a good idea lgtm Code looks good
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants