Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHDHPAI-160: merge ai-lab-helm-chart pipeline/task with rhdh-pipeline #60

Merged

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented Jan 14, 2025

What does this PR do?:

This change pulls in the recent rhdh-pipeline changes associated with RHDHPAI-160

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/RHDHPAI-160

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • [ /] Tested and Verified

Tested in conjunction with redhat-ai-dev/rhdh-pipelines#9

  • [ n/a] Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

How to test changes / Special notes to the reviewer:

A prior form of this PR's branch pointed to the branch associated with redhat-ai-dev/rhdh-pipelines#9 for the PAC pipeline and task refs.

I.e.

pipelinesascode.tekton.dev/pipeline: "https://raw.githubusercontent.com/gabemontero/rhdh-pipelines/refs/heads/upd-deploy-optional-steps/pac/pipelines/docker-build-ai-rhdh.yaml"

and

pipelinesascode.tekton.dev/task-3: "https://raw.githubusercontent.com/gabemontero/rhdh-pipelines/refs/heads/upd-deploy-optional-steps/pac/tasks/update-deployment.yaml"
pipelinesascode.tekton.dev/task-4: "https://raw.githubusercontent.com/gabemontero/rhdh-pipelines/refs/heads/upd-deploy-optional-steps/pac/tasks/update-deployment-patch.yaml"
pipelinesascode.tekton.dev/task-5: "https://raw.githubusercontent.com/redhat-ai-dev/rhdh-pipelines/main/pac/tasks/show-sbom-rhdh.yaml"
pipelinesascode.tekton.dev/task-6: "https://raw.githubusercontent.com/redhat-ai-dev/rhdh-pipelines/main/pac/tasks/summary.yaml"

However, once redhat-ai-dev/rhdh-pipelines#9 merges, only the form needed in this PR that adds the additional tasks and binding of the gitops-auth workspace is needed.

We will want to merge this soon after or in conjunction with redhat-ai-dev/rhdh-pipelines#9 as there will be a disconnect between the pipelineruns and the build pipeline in the interim.

@gabemontero
Copy link
Contributor Author

ah - missed the bit about https://docs.google.com/document/d/1hjZN6G-sDDkdSuXUZ12FkeaW5SoA64fgs1VejeOTfb4/edit?tab=t.0#heading=h.4wn8op67vyk9

will redo this PR by undoing / saving my original change, then run generate.sh and go from there

@gabemontero
Copy link
Contributor Author

so yeah the changes here are "for reference" ... I think I get it. Once redhat-ai-dev/rhdh-pipelines#9 merges I believe we run generate.sh to automate the changes I manually did here.

When I run it now, it effectively reverts my changes to what is in main branch in rhdh-pipelines

@gabemontero gabemontero force-pushed the upd-deploy-optional-steps branch 3 times, most recently from 6271759 to 61b6dc4 Compare January 16, 2025 22:23
This change pull in the recent rhdh-pipeline changes associated with RHDHPAI-160
@gabemontero
Copy link
Contributor Author

ok @Jdubrick @thepetk I've ran generate.sh with the merging of redhat-ai-dev/rhdh-pipelines#9 and the verify is green / passing now

the changes line up with what I manually tested with using that PR's ^^ branch off of my fork of rhdh-pipelines

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gabemontero gabemontero merged commit 99342fb into redhat-ai-dev:main Jan 17, 2025
1 check passed
@gabemontero gabemontero deleted the upd-deploy-optional-steps branch January 17, 2025 16:43
@thepetk
Copy link
Contributor

thepetk commented Jan 18, 2025

lgtm too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants