Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meminfo module #163

Closed
wants to merge 1 commit into from
Closed

Conversation

elfosardo
Copy link
Collaborator

@elfosardo elfosardo commented Feb 9, 2021

Use i2ctools to get info on memory.

Closes #162

Move get_ddr_timing to it and refactor detect.

This is also in preparation to get memory details using i2c-tools.
@ErwanAliasr1
Copy link
Contributor

The change is valid but I think we should drop this part. This information is not reliable. It uses legacy registers that were wrong on some on my hosts. I do think no one uses this part.

@ErwanAliasr1
Copy link
Contributor

I see your proposal around i2c-tools which has some interest to report the actual capability of the dimm but not how the memory controller is configured.
This code was about the memory controller which is very vendor/product dependant.
So switch to #162 would be way better

@elfosardo
Copy link
Collaborator Author

@ErwanAliasr1 do you think we should just remove this code then?
The conversion to i2c-tools is a big change and I thought to extract the old code from detect.py first.

@ErwanAliasr1
Copy link
Contributor

@elfosardo I imlplemented this when I was at enovance for my own usage. I'm pretty sure no one knows where this tool is located today, so the code is dead and useless. I'd vote for dropping this part.

@elfosardo
Copy link
Collaborator Author

removing the code in #164
I'll rebase this on top of that and use it to use i2ctools to get the memory info

@elfosardo elfosardo marked this pull request as draft February 16, 2021 13:25
@dtantsur
Copy link
Collaborator

#164

@dtantsur dtantsur closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_ddr_timing should use i2ctools
3 participants