Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace symbols missed when query includes package #98

Closed
2 tasks done
mickaelistria opened this issue Sep 13, 2023 · 1 comment
Closed
2 tasks done

Workspace symbols missed when query includes package #98

mickaelistria opened this issue Sep 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mickaelistria
Copy link
Collaborator

Let's make sure issue is not already fixed in snapshots first.

Steps to reproduce

From a fresh installation and clean workspace:

  • Create a project with a dummy java file
  • Ctrl+Shift+T to open symbols

I tried

  • querying java.awt.List

I expected: List from java.awt listed in the Open Symbols dialog

But got: empty output

Here is some relevant log output form (<workspace>/.metadata/.log)

It seems like a rendering issue as unveiled in eclipse-jdtls/eclipse.jdt.ls#2847 . The LS communication is

[2023-09-13T19:42:30.093925184+02:00] LSP4E_TO_LANGUAGE_SERVER com.redhat.eclipseide.jdtlsclient.inProcessServer:
{"jsonrpc":"2.0","id":"19026","method":"workspace/symbol","params":{"query":"java.awt.List"}}

[2023-09-13T19:42:30.235099509+02:00] LANGUAGE_SERVER_TO_LSP4E com.redhat.eclipseide.jdtlsclient.inProcessServer:
{"jsonrpc":"2.0","id":"19026","result":[{"name":"List","kind":5,"location":{"uri":"jdt://contents/java.desktop/java.awt/List.class?\u003dcom.redhat.eclipseide.jdtlsclient/%5C/usr%5C/lib%5C/jvm%5C/java-17-openjdk-17.0.8.0.7-1.fc38.x86_64%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/17%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/%3Cjava.awt(List.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt"},{"name":"List","kind":5,"location":{"uri":"jdt://contents/java.desktop/java.awt/List.class?\u003dorg.eclipse.jdt.core.compiler.batch/%5C/usr%5C/lib%5C/jvm%5C/java-20-openjdk%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/20%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/\u003d/add-exports\u003d/jdk.compiler%5C/com.sun.tools.javac.code%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.jvm%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.tree%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.parser%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.util%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.comp%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.file%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.main%5C\u003dALL-UNNAMED\u003d/%3Cjava.awt(List.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt"},{"name":"ListPeer","kind":11,"location":{"uri":"jdt://contents/java.desktop/java.awt.peer/ListPeer.class?\u003dcom.redhat.eclipseide.jdtlsclient/%5C/usr%5C/lib%5C/jvm%5C/java-17-openjdk-17.0.8.0.7-1.fc38.x86_64%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/17%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/%3Cjava.awt.peer(ListPeer.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt.peer"},{"name":"AccessibleAWTListChild","kind":5,"location":{"uri":"jdt://contents/java.desktop/java.awt/List$AccessibleAWTList$AccessibleAWTListChild.class?\u003dorg.eclipse.jdt.core.compiler.batch/%5C/usr%5C/lib%5C/jvm%5C/java-20-openjdk%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/20%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/\u003d/add-exports\u003d/jdk.compiler%5C/com.sun.tools.javac.code%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.jvm%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.tree%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.parser%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.util%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.comp%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.file%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.main%5C\u003dALL-UNNAMED\u003d/%3Cjava.awt(List$AccessibleAWTList$AccessibleAWTListChild.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt.List.AccessibleAWTList"},{"name":"AccessibleAWTList","kind":5,"location":{"uri":"jdt://contents/java.desktop/java.awt/List$AccessibleAWTList.class?\u003dorg.eclipse.jdt.core.compiler.batch/%5C/usr%5C/lib%5C/jvm%5C/java-20-openjdk%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/20%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/\u003d/add-exports\u003d/jdk.compiler%5C/com.sun.tools.javac.code%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.jvm%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.tree%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.parser%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.util%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.comp%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.file%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.main%5C\u003dALL-UNNAMED\u003d/%3Cjava.awt(List$AccessibleAWTList.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt.List"},{"name":"ListPeer","kind":11,"location":{"uri":"jdt://contents/java.desktop/java.awt.peer/ListPeer.class?\u003dorg.eclipse.jdt.core.compiler.batch/%5C/usr%5C/lib%5C/jvm%5C/java-20-openjdk%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/20%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/\u003d/add-exports\u003d/jdk.compiler%5C/com.sun.tools.javac.code%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.jvm%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.tree%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.parser%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.util%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.comp%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.file%5C\u003dALL-UNNAMED:jdk.compiler%5C/com.sun.tools.javac.main%5C\u003dALL-UNNAMED\u003d/%3Cjava.awt.peer(ListPeer.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt.peer"},{"name":"AccessibleAWTList","kind":5,"location":{"uri":"jdt://contents/java.desktop/java.awt/List$AccessibleAWTList.class?\u003dcom.redhat.eclipseide.jdtlsclient/%5C/usr%5C/lib%5C/jvm%5C/java-17-openjdk-17.0.8.0.7-1.fc38.x86_64%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/17%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/%3Cjava.awt(List$AccessibleAWTList.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt.List"},{"name":"AccessibleAWTListChild","kind":5,"location":{"uri":"jdt://contents/java.desktop/java.awt/List$AccessibleAWTList$AccessibleAWTListChild.class?\u003dcom.redhat.eclipseide.jdtlsclient/%5C/usr%5C/lib%5C/jvm%5C/java-17-openjdk-17.0.8.0.7-1.fc38.x86_64%5C/lib%5C/jrt-fs.jar%60java.desktop\u003d/javadoc_location\u003d/https:%5C/%5C/docs.oracle.com%5C/en%5C/java%5C/javase%5C/17%5C/docs%5C/api%5C/\u003d/\u003d/module\u003d/true\u003d/%3Cjava.awt(List$AccessibleAWTList$AccessibleAWTListChild.class","range":{"start":{"line":0,"character":0},"end":{"line":0,"character":0}}},"containerName":"java.awt.List.AccessibleAWTList"}]}

and shows the LS returns correct output.

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@mickaelistria
Copy link
Collaborator Author

Fixed in LSP4E with eclipse-lsp4e/lsp4e@e212fb7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant