Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible error when using archives with .tar.<extension> #217

Open
lstocchi opened this issue Feb 7, 2023 · 0 comments
Open

Possible error when using archives with .tar.<extension> #217

lstocchi opened this issue Feb 7, 2023 · 0 comments

Comments

@lstocchi
Copy link
Contributor

lstocchi commented Feb 7, 2023

          If the value of `archive` is `archiv.tar.bz2`, archiveType would not be correctly set.

I would have suggested to use path.basename instead of replace:

let archiveType = path.extname(archive);
if (path.extname(path.basename(archive)) === '.tar') {
  archiveType = '.tar' + archiveType;
}

Originally posted by @schurlinga in #215 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant