Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Request] Make the sleep after open-resources configurable #1544

Open
DavyLandman opened this issue Sep 29, 2024 · 1 comment
Open

[🚀 Request] Make the sleep after open-resources configurable #1544

DavyLandman opened this issue Sep 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DavyLandman
Copy link
Contributor

DavyLandman commented Sep 29, 2024

Describe the request

There is an explicit, non-skippable sleep inside openResources. There is no way to disable that, can we make that a parameter? Or alternatively replace it with some driver.wait call?

Usage

Every one of our tests opens a different file, and loose 3s on openResources everytime. We cannot batch the "open" calls. It would make our tests quite bit faster if we can drop the sleep, and just wait for the editor to show up with that file.

Which we already have to do, since sometimes on slow machines it can take longer to open a workspace than 3s. (or even sometimes a file)

PS: I'm more than happy to submit a PR to add a parameter with a default in there, if this has a chance of getting merged ;)

@DavyLandman DavyLandman added enhancement New feature or request new-issue New issue which was not discussed yet labels Sep 29, 2024
@DavyLandman
Copy link
Contributor Author

If someone runs into this as well, a work around is not to await on the openResources call/promise, but just monitor the open text editors for your file.

@djelinek djelinek removed the new-issue New issue which was not discussed yet label Oct 2, 2024
@djelinek djelinek self-assigned this Oct 2, 2024
@djelinek djelinek moved this from New to In Progress in ExTester Oct 2, 2024
@djelinek djelinek added this to the NEXT milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Review
Development

No branches or pull requests

2 participants