Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚫 Bug] Locators with class "inputarea" do not work in 1.97 preview #1715

Open
daniel-a126 opened this issue Jan 14, 2025 · 4 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@daniel-a126
Copy link

daniel-a126 commented Jan 14, 2025

Describe the bug

This is more of an FYI since I don't see that issue reported anywhere.

In 1.97 nightlies the textarea doesn't have the class inputarea and cannot be located e.g. by EditorView.setTextAtLine.

Steps to reproduce

1. Download VS Code nightly for 1.97
1. Run any test having **EditorView.setTextAtLine** in it

Logs

NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":".inputarea"}
     [java]   (Session info: chrome=128.0.6613.186)

Operating System

macOS 15.2

Visual Studio Code

1.97.0

vscode-extension-tester

8.10.0

NodeJS

18.20.4

npm

10.9.1

@daniel-a126 daniel-a126 added bug Something isn't working new-issue New issue which was not discussed yet labels Jan 14, 2025
@daniel-a126
Copy link
Author

I think the problem is more wide-spread; More stuff involving textareas doesn't work. Another example is OutputView.getText.

@jpogran
Copy link

jpogran commented Jan 17, 2025

I have been experiencing similar issues with locating .inputarea for the ExtensionView with 1.97 insiders.

jpogran added a commit to hashicorp/vscode-terraform that referenced this issue Jan 17, 2025
In #1938 we discovered the failures seem to be related to redhat-developer/vscode-extension-tester#1715 and VS Code Insiders 1.97.0. These failures may resolve with a new release of vscode-extension-tester or a new version of VS Code or they may not. We are skipping the tests for now to allow the dependency updates to merge and unblock future work
jpogran added a commit to hashicorp/vscode-terraform that referenced this issue Jan 21, 2025
In #1938 we discovered the failures seem to be related to redhat-developer/vscode-extension-tester#1715 and VS Code Insiders 1.97.0. These failures may resolve with a new release of vscode-extension-tester or a new version of VS Code or they may not. We are skipping the tests for now to allow the dependency updates to merge and unblock future work
jpogran added a commit to hashicorp/vscode-terraform that referenced this issue Jan 21, 2025
…ates (#1938)

* Bump the development-dependencies group across 1 directory with 4 updates

Bumps the development-dependencies group with 4 updates in the / directory: [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js), [eslint](https://github.com/eslint/eslint), [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint).


Updates `@eslint/js` from 9.17.0 to 9.18.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/commits/v9.18.0/packages/js)

Updates `eslint` from 9.17.0 to 9.18.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v9.17.0...v9.18.0)

Updates `eslint-config-prettier` from 9.1.0 to 10.0.1
- [Release notes](https://github.com/prettier/eslint-config-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v9.1.0...v10.0.1)

Updates `typescript-eslint` from 8.19.1 to 8.20.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.20.0/packages/typescript-eslint)

---
updated-dependencies:
- dependency-name: "@eslint/js"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: eslint-config-prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
- dependency-name: typescript-eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
...

Signed-off-by: dependabot[bot] <[email protected]>

* Skip extension install UI tests for VS Insiders 1.97.0

In #1938 we discovered the failures seem to be related to redhat-developer/vscode-extension-tester#1715 and VS Code Insiders 1.97.0. These failures may resolve with a new release of vscode-extension-tester or a new version of VS Code or they may not. We are skipping the tests for now to allow the dependency updates to merge and unblock future work

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: James Pogran <[email protected]>
@djelinek djelinek removed the new-issue New issue which was not discussed yet label Jan 24, 2025
@djelinek djelinek moved this from New to Todo in ExTester Jan 24, 2025
@djelinek djelinek added this to the NEXT milestone Jan 24, 2025
@daniel-a126
Copy link
Author

daniel-a126 commented Jan 27, 2025

@djelinek Hi Dominik, sorry, I'm a bit new to this whole process... Does the NEXT milestone's due date of 31 January mean that we will have a new release of vscode-extension-tester before 1.97 is released?

@djelinek
Copy link
Collaborator

djelinek commented Feb 3, 2025

Hello, thank you for raising this up.

Regarding support for new releases, I currently only have the capacity to cover and handle things in post-release, which means I always provide fixes and releases with full support for the next stable version of VS Code within a week of the release date.

It happened in past already that vscode-insiders has changed something which we were trying to reflect before stable reelase, but at the end the changes were not shipped into vscode-stable or it was changed again and so on. On behalf of that and lack of our time resources we had to switch and reflect changes after we really know what was changed in a stableversion.

Regarding milestones... The current NEXT milestone issues are candidates for upcoming development (1-2 months in terms of capacity) picked from the BACKLOG. The date is more an estimate of when at least one release should happen if no other is done during that period.

Regularly I also provide specific milestones that have a real release date planned, which I missed this time due to the reasons above, which I am sorry for, so your thoughts and questions are right. I will correct it as soon as possible.

@djelinek djelinek modified the milestones: NEXT, 8.12.0 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants