Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move package description to global variable and replace with it. #4

Open
6 tasks done
chkumar246 opened this issue Jul 12, 2017 · 8 comments
Open
6 tasks done
Assignees

Comments

@chkumar246
Copy link
Contributor

chkumar246 commented Jul 12, 2017

Currently, in most of the RDO packages, package description is copied at all the subpackage.
It looks redundant. It would be good if we can move replace common description used under all
subpackage to a variable and use that variable and replace the common description
with it.

How to reproduce:

  1. Clone openstack-nova spec file git clone https://github.com/rdo-packages/nova-distgit
  2. Go to nova-distgit and open openstack-nova.spec in editor
  3. We need to fix all the redundant contents under %description section for all subpackages in the given spec file.

How to fix:

  1. Define a common variable %global common_desc
  2. Replace go to %description section of all subpackage and replace common content
    with %{common_desc}
  3. Add the changes file, commit it and send a Gerrit review.
  4. Please cross checklist
    before sending Gerrit Review.

Here is the example spec file where it is fixed: https://github.com/rdo-packages/os-traits-distgit/blob/rpm-master/python-os-traits.spec

Below is the list of packages which need same fixes:

Mentor: chandankumar
Note: Pick one of the package and comment in the comment box with review link.

@rarguello
Copy link

openstack-nova Gerrit review: https://review.rdoproject.org/r/#/c/7731/

@rarguello
Copy link

openstack-glance Gerrit review: https://review.rdoproject.org/r/#/c/7732/

@rarguello
Copy link

openstack-cinder Gerrit review: https://review.rdoproject.org/r/#/c/7733/

@rarguello
Copy link

openstack-swift Gerrit review: https://review.rdoproject.org/r/#/c/7734/

@rarguello
Copy link

openstack-neutron Gerrit review: https://review.rdoproject.org/r/#/c/7735/

@rarguello
Copy link

openstack-keystone Gerrit review: https://review.rdoproject.org/r/#/c/7736/

@snecklifter
Copy link
Contributor

@rarguello cool, I'm doing this for python-senlinclient but if you wanted to do this for senlin itself, which just landed, that would be great!

@snecklifter
Copy link
Contributor

I'll have a look and see if this needs doing anywhere else. I suspect the answer is everywhere...

rdoproject pushed a commit to rdo-packages/manila-distgit that referenced this issue Sep 5, 2017
redhat-openstack/easyfix#4

Change-Id: I6312edecc118199599440148412706b89e6ad1fb
rdoproject pushed a commit to rdo-packages/ceilometer-distgit that referenced this issue Sep 5, 2017
redhat-openstack/easyfix#4

Change-Id: I6546aad790da03af8d4b252308d079ea0ecdff0c
rdoproject pushed a commit to rdo-packages/neutron-lbaas-distgit that referenced this issue Sep 5, 2017
redhat-openstack/easyfix#4

Change-Id: Icd20318833f2db260d4b066e0e6c6574a9635ea0
rdoproject pushed a commit to rdo-packages/oslo-middleware-distgit that referenced this issue Sep 5, 2017
redhat-openstack/easyfix#4

Change-Id: I9260421066ad0465fc01f969e30048395b64db15
rdoproject pushed a commit to rdo-packages/oslo-service-distgit that referenced this issue Sep 5, 2017
redhat-openstack/easyfix#4

Change-Id: Ifbc0422e461780b3981107cd957ea0cde31f287e
rdoproject pushed a commit to rdo-packages/tripleo-incubator-distgit that referenced this issue Sep 5, 2017
redhat-openstack/easyfix#4

Change-Id: I599a766abc2642e7075f7bd2667d0d3f7aadf8ce
rdoproject pushed a commit to rdo-packages/networking-bagpipe-distgit that referenced this issue Sep 7, 2017
redhat-openstack/easyfix#4

Change-Id: I284652889bc5d05c655a4942938a23c25aeefa7a
rdoproject pushed a commit to rdo-packages/vitrageclient-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: Idf8445331da031ddd3e7844ac06d0e6184ad4edd
rdoproject pushed a commit to rdo-packages/oslo-log-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I3f40a48293085654d9b29e65f4c9cce2fa56700c
rdoproject pushed a commit to rdo-packages/networking-l2gw-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I13ef6218bccfe826a64a8ce1a9333176f3f23488
rdoproject pushed a commit to rdo-packages/os-faults-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I779f3550b2f45d1a53e3f4a83e2629581e8d218e
rdoproject pushed a commit to rdo-packages/microversion-parse-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I80b503dc3b9a11bcc1ca6a7c39ae95ba4291f144
rdoproject pushed a commit to rdo-packages/cursive-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: Ic63efb067f392124ba6014d52b609d17e95289ae
rdoproject pushed a commit to rdo-packages/congressclient-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I696fe89cf441edcdca670f4a3d0ad693fe982eff
rdoproject pushed a commit to rdo-packages/congress-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I0ae6646560f409c1214f7779522ba545651e1876
rdoproject pushed a commit to rdo-packages/networking-fujitsu-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: Ibe210e08c9a37459c40e4d5d81e392c94296b8b6
rdoproject pushed a commit to rdo-packages/mox3-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I94def5b9cfc5fa00ff47db2080b3b0e9aebd1b1a
rdoproject pushed a commit to rdo-packages/oslo-concurrency-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I6256afca472af5170311af64b8f139c632160113
rdoproject pushed a commit to rdo-packages/openstackclient-distgit that referenced this issue Sep 12, 2017
redhat-openstack/easyfix#4

Change-Id: I58d249e9aad197246e1063f1fa4d3026c193cf71
rdoproject pushed a commit to rdo-packages/oslotest-distgit that referenced this issue Oct 24, 2017
redhat-openstack/easyfix#4

Change-Id: I63039477129569167e5beaf54c95ab26088daf1c
rdoproject pushed a commit to rdo-packages/osc-lib-distgit that referenced this issue Oct 24, 2017
redhat-openstack/easyfix#4

Change-Id: Id054a86f66c6681e916a8a6c1b006aea5fc9ac93
rdoproject pushed a commit to rdo-packages/oslo-db-distgit that referenced this issue Oct 24, 2017
redhat-openstack/easyfix#4

Change-Id: Ibfc2d37b6573977c86224bca4d6d7e419344c1f4
rdoproject pushed a commit to rdo-packages/glanceclient-distgit that referenced this issue Oct 24, 2017
redhat-openstack/easyfix#4

Change-Id: Idf6aa30cc32edc86d4e4b573ce587b6daa4de61a
rdoproject pushed a commit to rdo-packages/swiftclient-distgit that referenced this issue Oct 24, 2017
redhat-openstack/easyfix#4

Change-Id: I27959f8bafe80ad7f54c072b434ed64b1d763b1b
rdoproject pushed a commit to rdo-packages/oslo-i18n-distgit that referenced this issue Oct 24, 2017
redhat-openstack/easyfix#4

Change-Id: I7e3eb980e2084813b6cfaf5e4228759ad1d2faa8
rdoproject pushed a commit to rdo-packages/aodh-distgit that referenced this issue Oct 24, 2017
Capitalized API

redhat-openstack/easyfix#4

Change-Id: If830e2e0b85bc009e7ae6460d842d1373155604f
rdoproject pushed a commit to rdo-packages/ceilometerclient-distgit that referenced this issue Nov 14, 2017
redhat-openstack/easyfix#4

Change-Id: Ie93f5e0fdfac976b71bed9d97f6f4bd7180690fe
rdoproject pushed a commit to rdo-packages/cliff-distgit that referenced this issue Nov 14, 2017
redhat-openstack/easyfix#4

Change-Id: I66de75020540075fbd172c98fb033f3831c7ad64
rdoproject pushed a commit to rdo-packages/hardware-distgit that referenced this issue Nov 14, 2017
redhat-openstack/easyfix#4

Change-Id: I572fc1a15e51a56abcfb12691464d1dcb581263f
rdoproject pushed a commit to rdo-packages/cloudkittyclient-distgit that referenced this issue Nov 14, 2017
redhat-openstack/easyfix#4

Change-Id: I4d7fe4e3ae50cc6cae2c96e6eaf1c6f744eab72d
rdoproject pushed a commit to rdo-packages/mistral-distgit that referenced this issue Nov 16, 2017
redhat-openstack/easyfix#4

Change-Id: I5b5d9f0a7a77de3989d20f78e2c625a432c89ae1
rdoproject pushed a commit to rdo-packages/paunch-distgit that referenced this issue Nov 22, 2017
redhat-openstack/easyfix#4

Change-Id: I4d9696551c32a264c2845b0a07737f3d279c6747
rdoproject pushed a commit to rdo-packages/panko-distgit that referenced this issue Nov 22, 2017
redhat-openstack/easyfix#4

Change-Id: I23a6a7db5f7a35f96c38b997a5c7dc536bfd1e07
rdoproject pushed a commit to rdo-packages/murano-dashboard-distgit that referenced this issue Jan 25, 2018
redhat-openstack/easyfix#4

Change-Id: I2878d84ef95a2f7d64f628e6193a8a2b10d39921
rdoproject pushed a commit to rdo-packages/ovsdbapp-distgit that referenced this issue Jan 25, 2018
redhat-openstack/easyfix#4

Change-Id: Iae5e1cecb4f040bd984b259733ff4984072bd87b
rdoproject pushed a commit to rdo-packages/taskflow-distgit that referenced this issue Jan 25, 2018
redhat-openstack/easyfix#4

Change-Id: Ib637142d9440de0266fcdb6f70a447e55dc7f1c8
rdoproject pushed a commit to rdo-packages/magnum-ui-distgit that referenced this issue Jan 25, 2018
redhat-openstack/easyfix#4

Change-Id: I7f6043bc6d0d79e25a62eed52e44405daf5e39b6
rdoproject pushed a commit to rdo-packages/k8sclient-distgit that referenced this issue Jan 25, 2018
redhat-openstack/easyfix#4

Change-Id: Idfbd6fb835526842fd200a08331b1bd71f7493a3
rdoproject pushed a commit to rdo-packages/virtualbmc-distgit that referenced this issue Jan 25, 2018
redhat-openstack/easyfix#4

Change-Id: I20ed6f3a58f6ee19154824650c121f3af3ddadfc
rdoproject pushed a commit to rdo-packages/oslo-reports-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Change-id: I7cf7d247ff9bb75edda662931ea18a211968bf55
Subject: Moved the description to global variable redhat-openstack/easyfix#4
Branch: refs/heads/rpm-master
rdoproject pushed a commit to rdo-packages/oslo-reports-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Subject: Moved the description to global variable redhat-openstack/easyfix#4
Commit: 3139a96
rdoproject pushed a commit to rdo-packages/oslo-serialization-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Change-id: Iaf68fe81c3e23b303a39130b3cdabfa206099df0
Subject: Moved the description by global variable redhat-openstack/easyfix#4
Branch: refs/heads/rpm-master
rdoproject pushed a commit to rdo-packages/oslo-serialization-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Subject: Moved the description by global variable redhat-openstack/easyfix#4
Commit: 5f646a6
rdoproject pushed a commit to rdo-packages/sahara-distgit that referenced this issue Apr 4, 2024
Patch Set 2:

> I re-read the description, and in the end there is no much to
 > share. This last revision of the patch set a common variable for
 > two values which should be different.

Luigi this is part of an easyfix effort to standardise descriptions across all spec files. Please can you have a look at:

redhat-openstack/easyfix#4

Patch-set: 2
rdoproject pushed a commit to rdo-packages/shaker-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Change-id: I989a69d0cf77783b4de877ce78d6dcfbad702c65
Subject: Moved the description to global variable redhat-openstack/easyfix#4
Branch: refs/heads/rpm-master
rdoproject pushed a commit to rdo-packages/shaker-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Subject: Moved the description to global variable redhat-openstack/easyfix#4
Commit: 99a1fb7
rdoproject pushed a commit to rdo-packages/vitrageclient-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Change-id: I783cfb702e77a03c69e8d8ec39077bdadbc13df8
Subject: Moved the description to global variable redhat-openstack/easyfix#4
Branch: refs/heads/rpm-master
rdoproject pushed a commit to rdo-packages/vitrageclient-distgit that referenced this issue Apr 4, 2024
Patch-set: 1
Subject: Moved the description to global variable redhat-openstack/easyfix#4
Commit: 8e177bc
rdoproject pushed a commit to rdo-packages/vitrageclient-distgit that referenced this issue Apr 4, 2024
Patch Set 1:

Hello, thanks for contributing all these fixes!

Could you update the commit message with the full URL to the github issue on a new line:

redhat-openstack/easyfix#4

This means that the github ticket picks up the fix.

Patch-set: 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants