From f5b5bd7d5ca167b4edc6f0ea587ac3ca74410952 Mon Sep 17 00:00:00 2001 From: Thirumalesh Aaraveti Date: Wed, 4 Sep 2024 18:52:14 +0530 Subject: [PATCH] Add the subnet_id to terraform --- .github/workflows/Build.yml | 9 ++- .github/workflows/PR.yml | 81 ++++++++++---------- terraform/aws_instance/input_tfvars_template | 1 + terraform/aws_instance/main.tf | 7 +- terraform/aws_instance/tfvars_generator.py | 1 + 5 files changed, 52 insertions(+), 47 deletions(-) diff --git a/.github/workflows/Build.yml b/.github/workflows/Build.yml index d026a1cd..40534326 100644 --- a/.github/workflows/Build.yml +++ b/.github/workflows/Build.yml @@ -96,6 +96,7 @@ jobs: ROLE_NAME: ${{ secrets.ROLE_NAME }} REGION_NAME: ${{ secrets.TERRAFORM_REGION }} TAG_NAME: ${{ secrets.TAG_NAME }} + SUBNET_ID: ${{ SUBNET_ID }} run: | cd terraform/aws_instance # terrafrom apply @@ -109,7 +110,7 @@ jobs: integration: name: integration - needs: [unittest, terraform_apply] + needs: [ unittest, terraform_apply ] runs-on: ubuntu-latest strategy: max-parallel: 1 @@ -354,12 +355,12 @@ jobs: e2e: name: e2e - needs: [unittest, terraform_apply, integration, pypi_upload, pypi_validate, quay_upload, bump_version] + needs: [ unittest, terraform_apply, integration, pypi_upload, pypi_validate, quay_upload, bump_version ] runs-on: ubuntu-latest strategy: matrix: - region: ['us-east-1', 'us-east-2', 'us-west-1', 'us-west-2', 'eu-central-1', 'ap-south-1', 'eu-north-1', 'ap-northeast-1', 'ap-southeast-1', 'ap-southeast-2', 'eu-south-1', 'eu-west-3', 'sa-east-1'] - policy: ['instance_idle', 'instance_run', 'unattached_volume', 'ebs_in_use'] + region: [ 'us-east-1', 'us-east-2', 'us-west-1', 'us-west-2', 'eu-central-1', 'ap-south-1', 'eu-north-1', 'ap-northeast-1', 'ap-southeast-1', 'ap-southeast-2', 'eu-south-1', 'eu-west-3', 'sa-east-1' ] + policy: [ 'instance_idle', 'instance_run', 'unattached_volume', 'ebs_in_use' ] # we don't run zombie_cluster_resource due to long run steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/PR.yml b/.github/workflows/PR.yml index 534de334..293d5de7 100644 --- a/.github/workflows/PR.yml +++ b/.github/workflows/PR.yml @@ -5,7 +5,7 @@ name: PR on: pull_request_target: - types: [labeled, synchronize] + types: [ labeled, synchronize ] branches: [ main ] concurrency: @@ -23,49 +23,49 @@ jobs: unittest: name: unittest runs-on: ubuntu-latest - needs: [approve] + needs: [ approve ] strategy: matrix: python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ] steps: - - uses: actions/checkout@v4 - with: - ref: ${{ github.event.pull_request.head.sha }} - - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v5 - with: - python-version: ${{ matrix.python-version }} - - name: Install dependencies - run: | - # ldap requirements - sudo apt update -y - sudo apt-get install build-essential python3-dev libldap2-dev libsasl2-dev vim -y - python -m pip install --upgrade pip - pip install flake8 pytest pytest-cov - if [ -f requirements.txt ]; then pip install -r requirements.txt; fi - if [ -f tests_requirements.txt ]; then pip install -r tests_requirements.txt; fi - - name: Lint with flake8 - run: | - # stop the build if there are Python syntax errors or undefined names - flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics - # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide - flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics - - name: Configure AWS credentials for pytest - uses: aws-actions/configure-aws-credentials@v4 - with: - aws-access-key-id: ${{ secrets.ACCESS_KEY_ID }} - aws-secret-access-key: ${{ secrets.SECRET_ACCESS_KEY }} - aws-region: ${{ secrets.REGION }} - - name: 📃 Unittest tests with pytest - env: - BUCKET: ${{ secrets.BUCKET }} - REGION: ${{ secrets.REGION }} - run: | - python -m pytest -v tests/unittest + - uses: actions/checkout@v4 + with: + ref: ${{ github.event.pull_request.head.sha }} + - name: Set up Python ${{ matrix.python-version }} + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python-version }} + - name: Install dependencies + run: | + # ldap requirements + sudo apt update -y + sudo apt-get install build-essential python3-dev libldap2-dev libsasl2-dev vim -y + python -m pip install --upgrade pip + pip install flake8 pytest pytest-cov + if [ -f requirements.txt ]; then pip install -r requirements.txt; fi + if [ -f tests_requirements.txt ]; then pip install -r tests_requirements.txt; fi + - name: Lint with flake8 + run: | + # stop the build if there are Python syntax errors or undefined names + flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics + # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide + flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics + - name: Configure AWS credentials for pytest + uses: aws-actions/configure-aws-credentials@v4 + with: + aws-access-key-id: ${{ secrets.ACCESS_KEY_ID }} + aws-secret-access-key: ${{ secrets.SECRET_ACCESS_KEY }} + aws-region: ${{ secrets.REGION }} + - name: 📃 Unittest tests with pytest + env: + BUCKET: ${{ secrets.BUCKET }} + REGION: ${{ secrets.REGION }} + run: | + python -m pytest -v tests/unittest terraform_apply: name: terraform_apply - needs: [approve, unittest] + needs: [ approve, unittest ] runs-on: ubuntu-latest outputs: INSTANCE_ID: ${{ steps.terraform_instance_id.outputs.INSTANCE_ID }} @@ -100,6 +100,7 @@ jobs: ROLE_NAME: ${{ secrets.ROLE_NAME }} REGION_NAME: ${{ secrets.TERRAFORM_REGION }} TAG_NAME: ${{ secrets.TAG_NAME }} + SUBNET_ID: ${{ SUBNET_ID }} run: | cd terraform/aws_instance # terrafrom apply @@ -113,7 +114,7 @@ jobs: integration: name: integration - needs: [approve, unittest, terraform_apply] + needs: [ approve, unittest, terraform_apply ] runs-on: ubuntu-latest strategy: max-parallel: 1 @@ -186,7 +187,7 @@ jobs: terraform_destroy: name: terraform_destroy - needs: [approve, unittest, terraform_apply, integration] + needs: [ approve, unittest, terraform_apply, integration ] if: success() || failure() runs-on: ubuntu-latest steps: @@ -228,7 +229,7 @@ jobs: e2e: name: e2e - needs: [approve, unittest, terraform_apply, integration] + needs: [ approve, unittest, terraform_apply, integration ] runs-on: ubuntu-latest strategy: matrix: diff --git a/terraform/aws_instance/input_tfvars_template b/terraform/aws_instance/input_tfvars_template index 096c7d82..abcfccc1 100644 --- a/terraform/aws_instance/input_tfvars_template +++ b/terraform/aws_instance/input_tfvars_template @@ -2,6 +2,7 @@ instance_details = { "small_instance" = { "image_id" = "{{ image_id }}" "instance_type" = "{{ instance_type }}" + "subnet_id" = "{{ subnet_id }}" "tags" = { {% for key, value in tags.items() %} {{ key }} = "{{ value }}" diff --git a/terraform/aws_instance/main.tf b/terraform/aws_instance/main.tf index 23170d9a..7a105a89 100644 --- a/terraform/aws_instance/main.tf +++ b/terraform/aws_instance/main.tf @@ -1,6 +1,7 @@ resource "aws_instance" "main" { - for_each = var.instance_details + for_each = var.instance_details instance_type = each.value.instance_type - ami = each.value.image_id - tags = each.value.tags + ami = each.value.image_id + tags = each.value.tags + subnet_id = each.value.subnet_id } diff --git a/terraform/aws_instance/tfvars_generator.py b/terraform/aws_instance/tfvars_generator.py index a92f3da4..3ff782e5 100644 --- a/terraform/aws_instance/tfvars_generator.py +++ b/terraform/aws_instance/tfvars_generator.py @@ -13,6 +13,7 @@ def __init__(self): "tags": { "Name": os.environ['TAG_NAME'].strip("\n\t ") }, + "subnet_id": os.environ['SUBNET_ID'].strip("\n\t "), } except Exception as err: raise Exception(err)