Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin_cpu: allow raw energy_performance_preference values #715

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

ruihe774
Copy link
Contributor

@ruihe774 ruihe774 commented Dec 2, 2024

Besides values specified in energy_performance_available_preferences, energy_performance_preference also accepts numeric values to allow finer controlling. This PR allows valid numeric values for energy_performance_preference in plugin cpu.

@yarda
Copy link
Contributor

yarda commented Jan 16, 2025

Thanks, LGTM.

@yarda yarda merged commit b8392f9 into redhat-performance:master Jan 16, 2025
12 checks passed
@superm1
Copy link
Contributor

superm1 commented Feb 3, 2025

Besides values specified in energy_performance_available_preferences, energy_performance_preference also accepts numeric values to allow finer controlling. This PR allows valid numeric values for energy_performance_preference in plugin cpu.

FWIW this is only true on intel-pstate at the moment. But this field is actually used for any CPU that provides energy_performance_preference. So you need to be careful if any profiles start using numbers instead of strings because they will only work on intel-pstate.

There is a discussion on the mailing list that may change this in the future to allow other drivers to take raw EPP values, or there may be another string for other drivers (TBD).

You can follow along here: https://lore.kernel.org/linux-pm/[email protected]/

But I just want to provide this warning now to avoid future bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants