Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(RHEL-52634) Revert "cgroup-util: Don't try to open pidfd for kernel threads" #36

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jamacku
Copy link
Member

@jamacku jamacku commented Aug 28, 2024

The kernel patch was reverted so let's try again to open pidfds for kernel threads.

This reverts commit ead48ec35c863650944352a3455f26ce3b393058.

(cherry picked from commit 1ce69e06615e69692a6d02d447acfd77f5d44631)

follow-up to:

Copy link

github-actions bot commented Aug 28, 2024

Commit validation

Tracker - RHEL-52634

The following commits meet all requirements

commit upstream
ceaa867 - Revert "cgroup-util: Don't try to open pidfd for kernel threads" systemd/systemd@1ce69e0

Tracker validation

Success

🟢 Tracker RHEL-52634 has set desired product: rhel-10.0.beta
🟢 Tracker RHEL-52634 has set desired component: systemd
🟢 Tracker RHEL-52634 has been approved


Pull Request validation

Success

🟢 CI - All checks have passed
🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved


Auto Merge

Failed

🔴 Pull Request can't be merged, mergeable is null

Success

🟢 Pull Request is not marked as draft and it's not blocked by dont-merge label
🟢 Pull Request meet requirements, title has correct form
🟠 Pull Request doesn't meet requirements, mergeable_state is unknown
🟢 Pull Request has correct target branch main

Copy link
Member

@dtardon dtardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope the kernel doesn't break this again :-)

LGTM

The kernel patch was reverted so let's try again to open pidfds
for kernel threads.

This reverts commit ead48ec35c863650944352a3455f26ce3b393058.

(cherry picked from commit 1ce69e06615e69692a6d02d447acfd77f5d44631)

Related: RHEL-52634
@github-actions github-actions bot changed the title Revert "cgroup-util: Don't try to open pidfd for kernel threads" (RHEL-52634) Revert "cgroup-util: Don't try to open pidfd for kernel threads" Aug 30, 2024
@github-actions github-actions bot merged commit 3862333 into redhat-plumbers:main Aug 30, 2024
27 checks passed
@jamacku jamacku modified the milestones: RHEL-10.0, RHEL-10.0.BETA Sep 5, 2024
@jamacku jamacku deleted the revert-backport branch September 5, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants