Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lettuce 6.5.0.RELEASE does not provide the StatefulRedisConnectionImpl constructor that used to be provided in 6.4.0 #3054

Closed
tishun opened this issue Nov 18, 2024 · 2 comments · Fixed by #3065
Labels
type: blocker An issue that is blocking us from releasing type: regression A regression from a previous release
Milestone

Comments

@tishun
Copy link
Collaborator

tishun commented Nov 18, 2024

Bug Report

See redis/lettucemod#62

Current Behavior

The implementation of the RedisJSON commands introduced a new parser abstraction.
It is required to build the StatefulRedisConnectionImpl, but it used to not be part of the contract.

Expected behavior/code

We should avoid deprecating public API, especially without prior notice

@tishun tishun added this to the 6.5.1.RELEASE milestone Nov 18, 2024
@tishun tishun added type: blocker An issue that is blocking us from releasing type: regression A regression from a previous release labels Nov 18, 2024
@mmoayyed
Copy link

mmoayyed commented Dec 4, 2024

@tishun Thank you for working on this. I think there are still compatibility issues.

Trying 6.5.1, I see the following:

java.lang.NoSuchMethodError: 'void io.lettuce.core.RedisAsyncCommandsImpl.<init>(io.lettuce.core.api.StatefulRedisConnection, io.lettuce.core.codec.RedisCodec)'
	at com.redis.lettucemod.RedisModulesAsyncCommandsImpl.<init>(RedisModulesAsyncCommandsImpl.java:75)
	at com.redis.lettucemod.StatefulRedisModulesConnectionImpl.newRedisAsyncCommandsImpl(StatefulRedisModulesConnectionImpl.java:50)
	at com.redis.lettucemod.StatefulRedisModulesConnectionImpl.newRedisAsyncCommandsImpl(StatefulRedisModulesConnectionImpl.java:30)
	at io.lettuce.core.StatefulRedisConnectionImpl.<init>(StatefulRedisConnectionImpl.java:104)
	at io.lettuce.core.StatefulRedisConnectionImpl.<init>(StatefulRedisConnectionImpl.java:84)
	at com.redis.lettucemod.StatefulRedisModulesConnectionImpl.<init>(StatefulRedisModulesConnectionImpl.java:41)
	at com.redis.lettucemod.RedisModulesClient.newStatefulRedisConnection(RedisModulesClient.java:249)
	at com.redis.lettucemod.RedisModulesClient.newStatefulRedisConnection(RedisModulesClient.java:48)
	at io.lettuce.core.RedisClient.connectStandaloneAsync(RedisClient.java:290)
	at io.lettuce.core.RedisClient.connect(RedisClient.java:220)
	at com.redis.lettucemod.RedisModulesClient.connect(RedisModulesClient.java:198)
	at com.redis.lettucemod.RedisModulesClient.connect(RedisModulesClient.java:183)

@tishun
Copy link
Collaborator Author

tishun commented Dec 4, 2024

My bad. It was a huge change, should have checked all possible places.
Let me add this as another task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: blocker An issue that is blocking us from releasing type: regression A regression from a previous release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants