From 1260ede2a513870cde7f34d1e1232f193093e1a5 Mon Sep 17 00:00:00 2001 From: Ivo Jimenez Date: Fri, 8 Nov 2024 18:25:33 -0700 Subject: [PATCH 1/2] gha: remove reference to `vectorized` org This organization has been deprecated for a while now. Based on usage stats from dockerhub, zero pulls have been performed since july/2024, so customers/community aren't pulling from this org anymore and thus is safe to stop publishing to it. --- .github/workflows/docker-image.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml index 33cb767..bdfa21a 100644 --- a/.github/workflows/docker-image.yml +++ b/.github/workflows/docker-image.yml @@ -36,7 +36,6 @@ jobs: with: # list of Docker images to use as base name for tags images: | - vectorized/kminion redpandadata/kminion # generate Docker tags based on the following events/attributes # Semver type is only active on 'push tag' events, From 3a6b498bae6d6cd4039ab5512a82c053fe104c51 Mon Sep 17 00:00:00 2001 From: Ivo Jimenez Date: Fri, 8 Nov 2024 18:25:58 -0700 Subject: [PATCH 2/2] gha: remove hard-coded dockerhub username Change the secret being fetched by a new one that is named following our secret naming guidelines In addition, remove hard-coded username to allow easy change in the future of this value --- .github/workflows/docker-image.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/docker-image.yml b/.github/workflows/docker-image.yml index bdfa21a..5380d25 100644 --- a/.github/workflows/docker-image.yml +++ b/.github/workflows/docker-image.yml @@ -19,7 +19,7 @@ jobs: - uses: aws-actions/aws-secretsmanager-get-secrets@v2 with: secret-ids: | - ,sdlc/prod/github/dockerhub_token + ,sdlc/prod/github/dockerhub parse-json-secrets: true - uses: actions/checkout@v4 - uses: docker/setup-qemu-action@v3 @@ -45,7 +45,7 @@ jobs: type=semver,pattern={{raw}} - uses: docker/login-action@v3 with: - username: vectorizedbot + username: ${{ env.DOCKERHUB_USER }} password: ${{ env.DOCKERHUB_TOKEN }} - uses: docker/build-push-action@v6 with: