Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index not correct in fast_align.cc when computing emp_feat #62

Open
hitochan777 opened this issue Dec 15, 2014 · 0 comments
Open

index not correct in fast_align.cc when computing emp_feat #62

hitochan777 opened this issue Dec 15, 2014 · 0 comments

Comments

@hitochan777
Copy link

When computing emp_feat in fast_align.cc(line 205), I think index j should be j+1 since j start from 0.
emp_feat += DiagonalAlignment::Feature(j, i, trg.size(), src.size()) * p;

The other parts pass j+1 instead of j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant