Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8] Investigate updating the React-Redux benchmarks repo #1763

Closed
markerikson opened this issue Jul 9, 2021 · 8 comments
Closed

[v8] Investigate updating the React-Redux benchmarks repo #1763

markerikson opened this issue Jul 9, 2021 · 8 comments
Milestone

Comments

@markerikson
Copy link
Contributor

Background: #1740

After v6 turned out to be too slow, we wanted v7 to be really fast. I ended up creating a React-Redux benchmarks repo at https://github.com/reduxjs/react-redux-benchmarks , which has some stress tests for creating large trees in various scenarios, and dispatching many actions quickly. It then tries to measure number of re-renders and raw update FPS as a proxy for performance.

I haven't touched that repo since early 2019. I'd appreciate it if someone could look over that repo and see what might need to be done to prepare things for working with React 18 and some React-Redux v8 alphas.

It would also be good if we can figure out more stats to record in comparison, and maybe better proxies for performance than FPS.

@ryota-murakami
Copy link

@markerikson Since Looking npm trends search result, I confirmed Recoil doesn't getting a constant user rate.

Screen Shot 2021-07-09 at 11 07 05

So I decide migrate Recoil to 'Redux Toolkit' as an one of acceptable de facto standard State Management library, in this project.

Create React App TypeScript Todo Example 2021

I'll rewrite this weekend and I'd like this to be used for benchmarking purposes if that is helpful for your sake.

@markerikson
Copy link
Contributor Author

@ryota-murakami FWIW, for this issue I'm specifically interested in looking at the https://github.com/reduxjs/react-redux-benchmarks and seeing what needs to be done to get ready for updated performance testing with React-Redux v8 and React 18. Like, obviously some packages will need to be updated, but also I don't remember how the useSelector perf tests ended up being defined, or if they cover all the same scenarios that the connect tests do. I also want to see if we can improve how we're measuring "performance" here.

If you or anyone else comes up with additional benchmarks that would be useful too, but my main goal here is just the existing benchmarks repo.

@ryota-murakami
Copy link

@markerikson I see. I guess @dai-shi has some resource like that...

@dai-shi
Copy link
Contributor

dai-shi commented Jul 9, 2021

Well, reduxjs/react-redux-benchmarks#26 is my last work there. It should be easy to remove r-r-r, but the changes are still too big and duplicated.

If someone is gonna work on this, they can do a better way, because what we want to compare is r-r v7 and r-r v8 and comparing with connect is not primary.

@alk-mandrianarijaona
Copy link

Hello here, I am really interested in subjects around performance so I would love to give this a try. I will first take a look at https://github.com/reduxjs/react-redux-benchmarks to see how it works

@markerikson
Copy link
Contributor Author

@alk-mandrianarijaona
Copy link

@markerikson thanks for that, so what are the next steps you suggest I should look into?

@markerikson
Copy link
Contributor Author

@alk-mandrianarijaona : I just merged the one open PR I had over there . I think the next steps would be to update the React and React-Redux deps to use the latest React 18 and React-Redux v8 alphas, and then try to add more hooks-based equivalents of the existing connect-based usage scenarios.

@markerikson markerikson added this to the 8.0 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants