Make the build instructions work for Linux users. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if this fixes things for folks on BSD or whatever, and I've tried to make it clear I'm only sure about behaviour on Debian, but I hope this would be an improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this fixes things for folks on BSD or whatever, and I've tried to make it clear I'm only sure about behaviour on Debian, but I hope this would be an improvement.
This might fix #11, although that might also be a Python 2.X exclusive.
The use of
XDG_{whatever}_DESKTOPseems fragile (CURRENTis not present on my setup, butSESSIONis), so it might be worth usingplatform.systemif possible, perhaps? I'm not sure if this'd heck over folks who run posix-ish systems that aren't Linux-based, though; I guess whatever the check is based on should be better-aligned with whatever changes in the build configuration. Certainly, the behaviour whendetected_platformis unset isn't especially helpful.