From d9baca0bdfadeb3bc8d2e71e8e4de0bcaca6b8db Mon Sep 17 00:00:00 2001 From: lile Date: Thu, 23 Jan 2025 13:39:30 +0800 Subject: [PATCH] Fix #16978 AbstractDelayEvent compare method is incorrect --- .../engine/task/statemachine/TaskFailureStateAction.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/TaskFailureStateAction.java b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/TaskFailureStateAction.java index 196e28dfac89..63cf2ba9941b 100644 --- a/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/TaskFailureStateAction.java +++ b/dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/TaskFailureStateAction.java @@ -135,9 +135,10 @@ public void killEventAction(final IWorkflowExecutionRunnable workflowExecutionRu // there is no task executor now, shouldn't call workflowExecutionGraph.isTaskExecutionRunnableActive() // it's better to call super.killedEventAction() direct if (taskExecutionRunnable.isTaskInstanceCanRetry() - // && workflowExecutionGraph.isTaskExecutionRunnableActive(taskExecutionRunnable) + // && workflowExecutionGraph.isTaskExecutionRunnableActive(taskExecutionRunnable) ) { - super.killedEventAction(workflowExecutionRunnable, taskExecutionRunnable, TaskKilledLifecycleEvent.of(taskExecutionRunnable)); + super.killedEventAction(workflowExecutionRunnable, taskExecutionRunnable, + TaskKilledLifecycleEvent.of(taskExecutionRunnable)); return; } logWarningIfCannotDoAction(taskExecutionRunnable, taskKillEvent);