-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mui): add a loading spinner to <Show> component #6131
feat(mui): add a loading spinner to <Show> component #6131
Conversation
🦋 Changeset detectedLatest commit: 16a9d13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thanks for the detailed explanation 🚀 |
Hello again @paoloLigsay, the PR is great, thank you for your effort. However, after discussing with the core team, we decided to make some improvements regarding the design. The loading should be an overlay, ensuring that the children of the
Also, we need to add the same features to the Do you want to continue to work on this? |
Unfortunately this PR is left incomplete and we're closing this due to inactivity. If anyone is interested on working on this implementation, please let us know in the related issue 🙏 |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The
<Show>
component in the@refinedev/mui package
currently does not display a loading spinner when data is being fetched or processed, leaving users without visual feedback during loading states.What is the new behavior?
The
<Show>
component now includes a loading spinner that appears when theisLoading
prop is set totrue
. This provides users with a visual indication that data is being loaded during loading states. A test has been added to verify that the loading spinner renders when theisLoading
prop is set totrue
.fixes #5668
Notes for reviewers
The loading spinner added to the
<Show>
component is based on the behavior and color of the spinner used in the<List>
component. It utilizes the<CircularProgress>
component with its color set totheme.palette.primary.main
.See testing when
isLoading
is set toTrue
:when-loading-is-true.mov
See testing of the actual behavior:
actual-loading.mov
This is what the current loading spinner looks like in the
<List>
component:comparison-with-list-load.mov