Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Rename useSelect's queryResult to query. #6179

Closed
alicanerdurmaz opened this issue Jul 23, 2024 · 1 comment · Fixed by #6180
Closed

[FEAT] Rename useSelect's queryResult to query. #6179

alicanerdurmaz opened this issue Jul 23, 2024 · 1 comment · Fixed by #6180
Assignees
Labels
enhancement New feature or request

Comments

@alicanerdurmaz
Copy link
Member

alicanerdurmaz commented Jul 23, 2024

Is your feature request related to a problem? Please describe.

queryResult name is long.

const { queryResult, defaultValueQueryResult } = useSelect()

Describe the thing to improve

We can delete the result part for the name. this way it will be more readable.

const { query, defaultQuery } = useSelect()

Additional context

The following hooks should be refactored too.

  • useCheckboxGroup
  • useRadioGroup
  • useAutocomplete
@alicanerdurmaz alicanerdurmaz added the enhancement New feature or request label Jul 23, 2024
@alicanerdurmaz alicanerdurmaz added this to the August Release milestone Jul 23, 2024
@alicanerdurmaz alicanerdurmaz linked a pull request Jul 23, 2024 that will close this issue
5 tasks
@alicanerdurmaz alicanerdurmaz self-assigned this Jul 23, 2024
@osilviotti
Copy link

I'm not sure about this as a change - query and queryResult are semantically different. I would expect query to refer to what is being requested (like SQL queries).

If you wanted to shorten it, I think result works better and keeps the same meaning

@aliemir aliemir closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants