Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add guidelines for linting, formatting, and commit conventions #6238

Closed
wants to merge 1 commit into from

Conversation

Andrewx24
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes (issue)
Update ACT packagage since import {act} from 'react-dom/test-utils'; is deprcated

Notes for reviewers

@Andrewx24 Andrewx24 requested a review from a team as a code owner August 7, 2024 15:45
Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: c3c3d2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aliemir
Copy link
Member

aliemir commented Aug 7, 2024

Hey @Andrewx24, PR title and the change in the PR doesn't match, any chance that you've picked up the wrong branch or wrong title for it? We'll be waiting for the correction 😅

@aliemir
Copy link
Member

aliemir commented Aug 13, 2024

Closing due to inactivity. Thank you for your time! Let us know when you update the PR and we can check it again.

@aliemir aliemir closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants