fix(core): changes in props.id not reflected immediately in useResourceParams return type
#6260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36f5dea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
alicanerdurmaz
approved these changes
Aug 16, 2024
aliemir
force-pushed
the
releases/september
branch
2 times, most recently
from
ce864cd
to
6963e59
Compare
emrecancorapci
pushed a commit
to emrecancorapci/refine
that referenced
this pull request
Sep 4, 2024
…ourceParams` return type (refinedev#6260) (fixes refinedev#6259)
emrecancorapci
pushed a commit
to emrecancorapci/refine
that referenced
this pull request
Sep 4, 2024
…ourceParams` return type (refinedev#6260) (fixes refinedev#6259)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
useResourceParamshook was not reflecting the changes in theidprop immediately. This was due to theidstate being set in theuseEffecthook. This PR fixes the issue by setting theidstate properly during render rather than after the render is complete.Fixes #6259