feat(mui): Enhanced customisation in ThemedLayoutV2 #6502
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e2532c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aress31
changed the title
alicanerdurmaz
requested changes
Nov 20, 2024
Comment on lines
+84
to
+95
|
|
||
| /** | ||
| * Additional properties for the container box. | ||
| * This type includes all properties of BoxProps, including 'sx'. | ||
| */ | ||
| containerBoxProps?: BoxProps; | ||
|
|
||
| /** | ||
| * Additional properties for the children box. | ||
| * This type includes all properties of BoxProps, including 'sx'. | ||
| */ | ||
| childrenBoxProps?: BoxProps; |
There was a problem hiding this comment.
These types should be on @refinedev/mui package because @refinedev/ui-types packages used by other UI packages and these packages don't use these props.
BatuhanW
changed the title
alicanerdurmaz
changed the base branch from
master
to
releases/december-2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
See #6498.
What is the new behavior?
fixes (issue)
Notes for reviewers
I am not sure how to add the tests and where to add the doc, if you could walk me through the process for future contributions that would help.