Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mui): Fixed condition preventing Breadcrumb text display #6503

Open
wants to merge 17 commits into
base: releases/december-2024
Choose a base branch
from

Conversation

aress31
Copy link

@aress31 aress31 commented Nov 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

What is the new behavior?

fixes #6497

Notes for reviewers

The following tasks have not been performed, kindly complete them to provide me with a how-to example:

  • Tests for the changes have been added
  • Docs have been added / updated

@aress31 aress31 requested a review from a team as a code owner November 18, 2024 18:22
Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: 7639855

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@refinedev/chakra-ui Minor
@refinedev/ui-tests Minor
@refinedev/ui-types Minor
@refinedev/mantine Minor
@refinedev/antd Minor
@refinedev/mui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aress31 aress31 changed the title Patch for #6497 fix(mui): Fixed condition preventing Breadcrumb text display Nov 18, 2024
Copy link
Member

@BatuhanW BatuhanW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aress31 thanks for taking time to create issues and the PR.

In your PR, please do not include any irrelevant changes. Only the changes related to your fix and specs.

Imports like import HomeOutlined from "@mui/icons-material/HomeOutlined"; are not coincidence. They are intentionally like that because of bundling issues with mui library.

@BatuhanW BatuhanW linked an issue Nov 19, 2024 that may be closed by this pull request
@BatuhanW
Copy link
Member

@aress31 For tests, you can update the tests in packages/mui/src/components/breadcrumb/index.spec.tsx file. We have routerInitialEntries: ["/posts/create"], there, you can add new cases with routerInitialEntries: ["/posts"], and see if it renders. You can also stash your changes and run the test to see if new test correctly fails.

@aress31
Copy link
Author

aress31 commented Nov 19, 2024

Hey @aress31 thanks for taking time to create issues and the PR.

In your PR, please do not include any irrelevant changes. Only the changes related to your fix and specs.

Imports like import HomeOutlined from "@mui/icons-material/HomeOutlined"; are not coincidence. They are intentionally like that because of bundling issues with mui library.

@BatuhanW besides reverting the imports, what else do you want me to change? I think refactoring the file as I did help with modularity and readability - killing two birds with one stone.

@aress31
Copy link
Author

aress31 commented Nov 19, 2024

As requested, I focused solely on the fix. However, I recommend reviewing my previous commits with the refactoring. Some styles, such as default padding and fontSize, should, in my opinion, be removed to keep the component unstyled, allowing users to customize it via breadcrumbProps. Additionally, I suggest improving modularity by splitting the breadcrumb and home rendering logic.

Copy link
Member

@alicanerdurmaz alicanerdurmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @aress31, Thanks for improving Refine 🚀

I added comments to the issue about implementation. Please feel free to ask questions if you have any concerns

@alicanerdurmaz alicanerdurmaz changed the base branch from master to releases/december-2024 November 25, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Breadcumbs configure displayed elements
3 participants