Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customization-rtl): use Vazirmatn font #6536

Merged
merged 5 commits into from
Nov 29, 2024
Merged

Conversation

okaeiz
Copy link
Contributor

@okaeiz okaeiz commented Nov 28, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the current behavior?

The current font of RTL strings in languages such as Persian or Arabic is not aesthetically pleasing and causes problems in readability in some screens.

What is the new behavior?

The ideal solution is to use a readable font that is widely used in these languages. I have used Vazirmatn which a popular font.

Notes for reviewers

I have not opened an issue for this. I decided to interact with the viewers under the PR, If I may. This PR only changes the code in customization-rtl template.

The default font for RTL languages such as Arabic and Persian is not aesthetically pleasing. Vazirmatn is an open-source font that is widely used in RTL UIs.
@okaeiz okaeiz requested a review from a team as a code owner November 28, 2024 10:18
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 997f512

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BatuhanW
Copy link
Member

Hey @okaeiz thanks for the PR. Since it's a PR against example, not creating issue is not a big problem.

Could you share before/after screenshots for this change?

@okaeiz
Copy link
Contributor Author

okaeiz commented Nov 28, 2024

Hey @okaeiz thanks for the PR. Since it's a PR against example, not creating issue is not a big problem.

Could you share before/after screenshots for this change?

Sure thing. As you probably know, Github itself uses Vazirmatn font for Arabic and Persian characters. Take a look at the font's official repository. Here are the screenshots:

Before

1

After

2

As you can notice, the letters are too close to each other in the default font. Since Arabic and Persian letters often have close dots and small dents, if they are too close, they can be indistinguishable. But Vazirmatn resolves the issue by putting adequate space between letters.

@BatuhanW BatuhanW changed the title Apply Vazirmatn font for RTL strings in languages such as Arabic and Persian feat(customization-rtl): use Vazirmatn font Nov 28, 2024
@BatuhanW
Copy link
Member

@okaeiz thanks for the contribution. Please see the message at the very beginning of PR description.

Following conventions makes our lives easier, keep in mind next time ❤️

@okaeiz
Copy link
Contributor Author

okaeiz commented Nov 28, 2024

@okaeiz thanks for the contribution. Please see the message at the very beginning of PR description.

Following conventions makes our lives easier, keep in mind next time ❤️

I'll keep that in mind. Thank you.
Should I create a PR anew in order for this feature to be merged?

@BatuhanW BatuhanW merged commit 0d6d062 into refinedev:master Nov 29, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants