-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(customization-rtl): use Vazirmatn font #6536
Conversation
The default font for RTL languages such as Arabic and Persian is not aesthetically pleasing. Vazirmatn is an open-source font that is widely used in RTL UIs.
|
Hey @okaeiz thanks for the PR. Since it's a PR against example, not creating issue is not a big problem. Could you share before/after screenshots for this change? |
Sure thing. As you probably know, Github itself uses Vazirmatn font for Arabic and Persian characters. Take a look at the font's official repository. Here are the screenshots: BeforeAfterAs you can notice, the letters are too close to each other in the default font. Since Arabic and Persian letters often have close dots and small dents, if they are too close, they can be indistinguishable. But Vazirmatn resolves the issue by putting adequate space between letters. |
@okaeiz thanks for the contribution. Please see the message at the very beginning of PR description. Following conventions makes our lives easier, keep in mind next time ❤️ |
I'll keep that in mind. Thank you. |
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
The current font of RTL strings in languages such as Persian or Arabic is not aesthetically pleasing and causes problems in readability in some screens.
What is the new behavior?
The ideal solution is to use a readable font that is widely used in these languages. I have used Vazirmatn which a popular font.
Notes for reviewers
I have not opened an issue for this. I decided to interact with the viewers under the PR, If I may. This PR only changes the code in
customization-rtl
template.