fix(live-previews): fix replacement of the scoped default imports #5967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
In the live preview code we're replacing imports with provided scopes of packages.
Example:
will be replaced with:
In some cases, imports may be made with subpaths/scopess of a package;
Example:
In this case we've been replacing it with the same structure:
This replacement was using the default import name (in this case
Button
) but it was flawed because the default import name don't have to match the actual export name.Example:
In this case, a broken replacement is made:
This caused
Button$1
to beundefined
and break the preview.In this PR, we've made a small change in this logic to use scope name and have a name change in the destructuring process.
Example:
will be replaced with