Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Remember search query" config setting does not take effect #734

Closed
Moj-FPS opened this issue Dec 3, 2024 · 5 comments
Closed

"Remember search query" config setting does not take effect #734

Moj-FPS opened this issue Dec 3, 2024 · 5 comments
Labels
bug Something isn't working can't reproduce We are unable to reproduce this issue

Comments

@Moj-FPS
Copy link

Moj-FPS commented Dec 3, 2024

Describe the bug

The previous search term in the search bar of the crafting grid is always shown. The config value for "Remember search query" is set to "OFF" by default. Toggling it to "ON" and back to "OFF" had no effect.

How can we reproduce this bug or crash?

  1. Check crafting grid config for "Remember search query"
  2. Set to "OFF"
  3. Type in search term in crafting grid
  4. Exit crafting grid
  5. Enter crafting grid
  6. Search term is still displayed

What Minecraft version is this happening on?

Minecraft 1.21.1

What NeoForge or Fabric version is this happening on?

NeoForge 21.1.81

What Refined Storage version is this happening on?

2.0.0-milestone.4.10

Relevant log output

N/A
@Moj-FPS Moj-FPS added the bug Something isn't working label Dec 3, 2024
@raoulvdberge raoulvdberge added this to the v2.0.0-milestone.4 milestone Dec 4, 2024
@raoulvdberge raoulvdberge moved this from Todo to In Progress in Refined Storage 2 Dec 7, 2024
@raoulvdberge
Copy link
Contributor

I cannot reproduce this. When I set it from "ON" to "OFF", the contents of the text field are always cleared when opening the grid.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Refined Storage 2 Dec 7, 2024
@raoulvdberge raoulvdberge added the can't reproduce We are unable to reproduce this issue label Dec 7, 2024
@raoulvdberge raoulvdberge removed this from the v2.0.0-milestone.4 milestone Dec 7, 2024
@raoulvdberge
Copy link
Contributor

I'll close this for now. Can you retry with your reproduction steps and report back if you can still reproduce it?

@Moj-FPS
Copy link
Author

Moj-FPS commented Dec 7, 2024 via email

@Moj-FPS
Copy link
Author

Moj-FPS commented Dec 8, 2024

I figured it out. I had it set to Two-Way JEI Synchronization, so since JEI was remembering the search query it was automatically in RS. Switched it back to one-way and it works just fine. 🤦‍♂️ My bad!

@raoulvdberge
Copy link
Contributor

No worries, thanks for reporting anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce We are unable to reproduce this issue
Projects
None yet
Development

No branches or pull requests

2 participants