Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix assignment of default configuration parameters across systems #3377

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

teojgo
Copy link
Contributor

@teojgo teojgo commented Feb 3, 2025

Fixes #3371

@teojgo teojgo added this to the ReFrame 4.7.4 milestone Feb 3, 2025
@teojgo teojgo requested review from vkarak and victorusu February 3, 2025 12:55
@teojgo teojgo self-assigned this Feb 3, 2025
unittests/resources/config/settings.py Show resolved Hide resolved
unittests/test_config.py Outdated Show resolved Hide resolved
reframe/core/config.py Outdated Show resolved Hide resolved
reframe/core/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@vkarak
Copy link
Contributor

vkarak commented Feb 7, 2025

I was about to merge it, but realised it targets develop. I'll rebase it to master and then merge, so that we roll it out for 4.7.4.

@teojgo teojgo force-pushed the bugfix/immutable_default_extras branch from fadeab7 to 9842e68 Compare February 7, 2025 11:17
@vkarak vkarak force-pushed the bugfix/immutable_default_extras branch from c307423 to aa62ec9 Compare February 7, 2025 12:06
@vkarak vkarak changed the base branch from develop to master February 7, 2025 12:07
@vkarak vkarak changed the title [bugfix] Copy mutable default configuration parameters [bugfix] Fix assignment of default configuration parameters across systems Feb 7, 2025
@vkarak vkarak enabled auto-merge February 7, 2025 12:13
@vkarak vkarak merged commit f214fb5 into reframe-hpc:master Feb 7, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checks filtering using valid programs shows only the first partition defined in the configuration
2 participants