Skip to content

Commit

Permalink
Workflows: Downgrade linux distro
Browse files Browse the repository at this point in the history
  • Loading branch information
@s1lentq
s1lentq committed Jul 27, 2024
1 parent 1991434 commit 576e967
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
linux:
name: 'Linux'
runs-on: ubuntu-latest
runs-on: ubuntu-20.04

steps:
- name: Checkout
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:

- name: Build using Clang C++ Compiler
run: |
rm -rf build && CC=clang CXX=clang++ cmake -DUSE_LEGACY_LIBC=ON -B build && cmake --build build -j8
rm -rf build && CC=clang CXX=clang++ cmake -B build && cmake --build build -j8
- name: Prepare CSSDK
run: |
Expand Down

2 comments on commit 576e967

@StevenKal
Copy link
Contributor

@StevenKal StevenKal commented on 576e967 Jul 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1lentq :
The following GitHub default compiler issue:
Post job cleanup. /usr/bin/docker exec b721af1365ccd151c94d44dad748b9b2e3301e83fcc6af9eb629f277de38fe3b sh -c "cat /etc/*release | grep ^ID" /__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.28' not found (required by /__e/node20/bin/node)`

Which started happenned, like 15 days, ago (we can see it there), I constated by wanting to properly replicate your compiler changes (from commit here and later) to my own ReGameDLL_CS of my servers (I run Debian 12 on it), an instant server crash when I am detonating my satchels (or laser mines) grenades from a personal plugin, which, should not happen & did not before... Server crash with no "Engine error" (GoldSrc error).
I am a massive noob with compilers & their options but I am guessing the changes from ICC to Clang or possibility some options might lead to such issues, and other people might got a similar & anormal crash due to such, if running third-party plugins.

No one reported it yet because people barely download & use the compiled versions in "Actions", but this might.
Will it be possible to fork it & put back a ICC compilable project for Linux? As Before? Thanks in advance.
Or if you know a quick solution to fix the quoted compiler error (GLIBC_2.28...) by keeping ICC for Linux, I will be glad to try it & report you if this fix my serious issue.

@StevenKal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1lentq: The addition of this line below in workflows/build.yml:
env: ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

Was enough to fix my serious issue, I may suggest to undo all your previous compiler changes (from this point) to just "this one above". Because the crash I got with new changes was anormal & other people might got same issues with third-party plugins...

Please sign in to comment.