Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fetch truth twice when current_date == selected_as_of_date #17

Open
matthewcornell opened this issue Nov 30, 2022 · 0 comments
Open
Assignees

Comments

@matthewcornell
Copy link
Member

I noticed that when the component first loads, it calls the same truth API call twice: fetchDataUpdatePlot() calls fetchAsOfTruth() and then fetchCurrentTruth() even though the underlying dates are the initially the same (App.state.selected_as_of_date and App.state.current_date, respectively). This issue is for a fetchDataUpdatePlot() optimization that copies results from fetchAsOfTruth() (App.state.as_of_truth) to App.state.current_truth instead of calling fetchCurrentTruth().

@matthewcornell matthewcornell self-assigned this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant