Skip to content
This repository has been archived by the owner on Nov 20, 2019. It is now read-only.

Try to avoid reporting stale metrics #33

Open
rtyler opened this issue Aug 31, 2015 · 1 comment
Open

Try to avoid reporting stale metrics #33

rtyler opened this issue Aug 31, 2015 · 1 comment

Comments

@rtyler
Copy link
Member

rtyler commented Aug 31, 2015

With consumer groups that were short-lived ephemeral consumer groups we should not attempt to report metrics on those up to the metrics provider.

This will prevent us from unnecessarily reporting metrics on consumers which haven't updated anything in, say, two weeks.

@rtyler rtyler modified the milestone: 0.4.0 - RE 17070 Sep 1, 2015
@rtyler
Copy link
Member Author

rtyler commented Sep 2, 2015

The more I think about this the less convinced I am of one solution over another. Basically Verspaetung registers a ConsumerGauge with the internal MetricsRegistry and the getValue call will simply look up the latest values in the map of KafkaConsumer objects for that topic and TopicPartition objects for the latest metadata.

Since this all happens from within the getValue call we can't very well remove ourselves from the MetricsRegistrythere can we? We would also need to clean up the map with KafkaConsumer objects there too.

@rtyler rtyler removed this from the 0.4.0 - RE 17070 milestone Sep 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

1 participant