Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's try again #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Let's try again #16

wants to merge 2 commits into from

Conversation

jpresern
Copy link
Contributor

No description provided.

@jpresern
Copy link
Contributor Author

I tried to fix some issue, but this git is a quagmire, really ;)

@@ -138,11 +137,11 @@ def parse_structure(filename, verbose=False):
structure.append(FileRange(start, line_no, 'data'))
within_data_block = False
if verbose: print("DATA END", line[:20], line_no)
elif within_meta_block:
if within_meta_block:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying understand the logic. Why replace it with if here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

argh...

man, another of those. I reverted few changes, but this one is one that
I did not.
Keep the original, the whole def parse_structure as it is.

Sorry Fabian.

On 11.03.16 15:59, Fabian Sinz wrote:

In pyrelacs/DataClasses/RelacsFile.py
#16 (comment):

@@ -138,11 +137,11 @@ def parse_structure(filename, verbose=False):
structure.append(FileRange(start, line_no, 'data'))
within_data_block = False
if verbose: print("DATA END", line[:20], line_no)

  •            elif within_meta_block:
    
  •            if within_meta_block:
    

Trying understand the logic. Why replace it with |if| here?


Reply to this email directly or view it on GitHub
https://github.com/relacs/pyrelacs/pull/16/files#r55839297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants