Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strikethrough not handled properly #34

Closed
4 tasks done
MichalPaszowski opened this issue Oct 10, 2024 · 2 comments
Closed
4 tasks done

Strikethrough not handled properly #34

MichalPaszowski opened this issue Oct 10, 2024 · 2 comments
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on

Comments

@MichalPaszowski
Copy link

MichalPaszowski commented Oct 10, 2024 •
edited
Loading

Initial checklist

Affected packages and versions

"strip-markdown": "^6.0.0", "remark": "^14.0.3",

Link to runnable example

No response

Steps to reproduce

Parsing
~~test~~
results in:
\~~test~~

Expected behavior

Parsing
~~test~~
should result in:
test

Actual behavior

Parsing
~~test~~
results in:
\~~test~~

Affected runtime and version

chrome 129.0.6668.90

Affected package manager and version

No response

Affected OS and version

No response

Build and bundle tools

No response
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 10, 2024
@wooorm
Copy link
Member

wooorm commented Oct 10, 2024

Strikethrough is not a markdown (commonmark) feature, so it is not available by default. You are looking for remark-gfm, as it is a GFM feature

@wooorm wooorm closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@wooorm wooorm added the 🙋 no/question This does not need any changes label Oct 10, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋 no/question This does not need any changes 👎 phase/no Post cannot or will not be acted on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wooorm @MichalPaszowski