Allow NewDynamoDBClient to accept a client.ConfigProvider.

remind101 · Jun 26, 2018 · 46305d4 · 46305d4
1 parent 8339ebe
commit 46305d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/dynamodb_client/base_table_client_test.go b/dynamodb_client/base_table_client_test.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/aws/aws-sdk-go/aws"
+	"github.com/aws/aws-sdk-go/aws/session"
 	"github.com/aws/aws-sdk-go/service/dynamodb"
 	"github.com/aws/aws-sdk-go/service/dynamodb/dynamodbattribute"
 	. "github.com/remind101/pkg/dynamodb_client"
@@ -57,7 +58,7 @@ func newFreshDynamoClient() *DynamoClient {
 		Scope:             "client-test",
 		TableDescriptions: AllTableDescriptions,
 	}
-	c := NewDynamoDBClient(params)
+	c := NewDynamoDBClient(session.New(), params)
 	c.DeleteTables()
 	c.CreateTables()
 	return c

diff --git a/dynamodb_client/dynamo.go b/dynamodb_client/dynamo.go
@@ -6,7 +6,7 @@ import (
 
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/awserr"
-	"github.com/aws/aws-sdk-go/aws/session"
+	"github.com/aws/aws-sdk-go/aws/client"
 	"github.com/aws/aws-sdk-go/service/dynamodb"
 	"github.com/aws/aws-sdk-go/service/dynamodb/dynamodbiface"
 	"github.com/remind101/pkg/logger"
@@ -26,15 +26,15 @@ type DynamoConnectionParams struct {
 	ServiceName       string // Name to use in apm
 }
 
-func NewDynamoDBClient(params DynamoConnectionParams) *DynamoClient {
+func NewDynamoDBClient(c client.ConfigProvider, params DynamoConnectionParams) *DynamoClient {
 	if params.RegionName == "" {
 		params.RegionName = "us-east-1"
 	}
 	config := aws.Config{
 		Region:   aws.String(params.RegionName),
 		Endpoint: aws.String(params.LocalDynamoURL),
 	}
-	svc := dynamodb.New(session.New(), &config)
+	svc := dynamodb.New(c, &config)
 	//svc.Handlers.Retry.PushFrontNamed(CheckThrottleHandler)
 
 	return &DynamoClient{